Drop return value from RtpRtcp::IncomingRtcpPacket.

Drop return value from RtpRtcp::IncomingRtcpPacket.

And from its callee RTCPReceiver::IncomingPacket.

BUG=webrtc:5565
Review-Url: https://codereview.webrtc.org/3009403002
Cr-Commit-Position: refs/heads/master@{#19823}
Committed: https://chromium.googlesource.com/external/webrtc/+/479d3d75df72a46956f1336cb969085080064971

[nisse-webrtc, 2017-09-13 10:42:33]

nisse@webrtc.org changed reviewers:
+ danilchap@webrtc.org, solenberg@webrtc.org

[nisse-webrtc, 2017-09-13 10:42:34]

Does it make sense to drop this almost unused return value? There seem to be
some downstream breakage.

If we do this, I wonder what it would take to also drop corresponding return
value from the webrtc::Transport interface, which is a public api.

[danilchap, 2017-09-13 10:52:27]

Description was changed from

==========
Drop return value from RtpRtcp::IncomingRtcpPacket.

And from its callee RTCPReceiver::IncomingPacket.

BUG=None
==========

to

==========
Drop return value from RtpRtcp::IncomingRtcpPacket.

And from its callee RTCPReceiver::IncomingPacket.

BUG=webrtc:5565
==========

[danilchap, 2017-09-13 11:19:13]

it does make sense to me.
current return value is not very consistent: it return false if rtcp packet is
malformed in the begining (nothing was extracted), but tail malformed blocks are
counted and logged separetly. Prefer to keep only the latter.

https://codereview.webrtc.org/3009403002/diff/20001/webrtc/modules/rtp_rtcp/t...
File webrtc/modules/rtp_rtcp/test/testAPI/test_api.cc (right):

https://codereview.webrtc.org/3009403002/diff/20001/webrtc/modules/rtp_rtcp/t...
webrtc/modules/rtp_rtcp/test/testAPI/test_api.cc:65:
rtp_rtcp_module_->IncomingRtcpPacket((const uint8_t*)data, len);
mind removing unneeded c-cast while touching this line?

[danilchap, 2017-09-13 12:03:14]

lgtm

[nisse-webrtc, 2017-09-13 14:01:43]

Internal bot seems to pass now. Thanks danil!

Fredrik, do you want to have a look at the small voice_engine changes?

[the sun, 2017-09-13 14:14:57]

lgtm for voice_engine/

[nisse-webrtc, 2017-09-13 14:16:35]

The CQ bit was checked by nisse@webrtc.org

[commit-bot: I haz the power, 2017-09-13 14:16:45]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-09-13 14:53:38]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1505312195126550,
"parent_rev": "9a85f0782ea4647d77515b48b4bd2e1b0826210a", "commit_rev":
"479d3d75df72a46956f1336cb969085080064971"}

[commit-bot: I haz the power, 2017-09-13 14:53:43]

Description was changed from

==========
Drop return value from RtpRtcp::IncomingRtcpPacket.

And from its callee RTCPReceiver::IncomingPacket.

BUG=webrtc:5565
==========

to

==========
Drop return value from RtpRtcp::IncomingRtcpPacket.

And from its callee RTCPReceiver::IncomingPacket.

BUG=webrtc:5565

Review-Url: https://codereview.webrtc.org/3009403002
Cr-Commit-Position: refs/heads/master@{#19823}
Committed:
https://chromium.googlesource.com/external/webrtc/+/479d3d75df72a46956f1336cb...
==========

[commit-bot: I haz the power, 2017-09-13 14:53:45]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/external/webrtc/+/479d3d75df72a46956f1336cb...