webrtc/modules/rtp_rtcp/test/testAPI/test_api.cc - Issue 3009403002: Drop return value from RtpRtcp::IncomingRtcpPacket.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/modules/rtp_rtcp/test/testAPI/test_api.cc

Issue 3009403002: Drop return value from RtpRtcp::IncomingRtcpPacket. (Closed)

Patch Set: Delete VoENetworkTest.ReceivedRTCPPacketWithJunkDataShouldFail. Created 3 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: webrtc/modules/rtp_rtcp/test/testAPI/test_api.cc

diff --git a/webrtc/modules/rtp_rtcp/test/testAPI/test_api.cc b/webrtc/modules/rtp_rtcp/test/testAPI/test_api.cc

index b39c8d72dae16fee1e8477083bfaaa25a401bced..695b797b905827601831c75c0d57fd00f3e95a40 100644

--- a/webrtc/modules/rtp_rtcp/test/testAPI/test_api.cc

+++ b/webrtc/modules/rtp_rtcp/test/testAPI/test_api.cc

@@ -62,9 +62,7 @@ bool LoopBackTransport::SendRtp(const uint8_t* data,

}

bool LoopBackTransport::SendRtcp(const uint8_t* data, size_t len) {

- if (rtp_rtcp_module_->IncomingRtcpPacket((const uint8_t*)data, len) < 0) {

- return false;

- }

+ rtp_rtcp_module_->IncomingRtcpPacket((const uint8_t*)data, len);

danilchap 2017/09/13 11:19:13 mind removing unneeded c-cast while touching this

return true;

}