Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(309)

Unified Diff: webrtc/modules/rtp_rtcp/source/rtp_rtcp_impl_unittest.cc

Issue 3009403002: Drop return value from RtpRtcp::IncomingRtcpPacket. (Closed)
Patch Set: Delete VoENetworkTest.ReceivedRTCPPacketWithJunkDataShouldFail. Created 3 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/modules/rtp_rtcp/source/rtp_rtcp_impl_unittest.cc
diff --git a/webrtc/modules/rtp_rtcp/source/rtp_rtcp_impl_unittest.cc b/webrtc/modules/rtp_rtcp/source/rtp_rtcp_impl_unittest.cc
index b417591af12f8c9f00780e0304e84bed1f1f5049..aa9db2af7a09feeff9f4ee0d56fbf78b4b7ebb59 100644
--- a/webrtc/modules/rtp_rtcp/source/rtp_rtcp_impl_unittest.cc
+++ b/webrtc/modules/rtp_rtcp/source/rtp_rtcp_impl_unittest.cc
@@ -88,7 +88,7 @@ class SendTransport : public Transport,
clock_->AdvanceTimeMilliseconds(delay_ms_);
}
EXPECT_TRUE(receiver_);
- EXPECT_EQ(0, receiver_->IncomingRtcpPacket(data, len));
+ receiver_->IncomingRtcpPacket(data, len);
return true;
}
int32_t OnReceivedPayloadData(const uint8_t* payload_data,
@@ -255,8 +255,7 @@ class RtpRtcpImplTest : public ::testing::Test {
nack.SetMediaSsrc(sender ? kSenderSsrc : kReceiverSsrc);
nack.SetPacketIds(list, kListLength);
rtc::Buffer packet = nack.Build();
- EXPECT_EQ(0, module->impl_->IncomingRtcpPacket(packet.data(),
- packet.size()));
+ module->impl_->IncomingRtcpPacket(packet.data(), packet.size());
}
};

Powered by Google App Engine
This is Rietveld 408576698