Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(107)

Unified Diff: webrtc/voice_engine/channel.cc

Issue 3009403002: Drop return value from RtpRtcp::IncomingRtcpPacket. (Closed)
Patch Set: Delete VoENetworkTest.ReceivedRTCPPacketWithJunkDataShouldFail. Created 3 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/voice_engine/channel.cc
diff --git a/webrtc/voice_engine/channel.cc b/webrtc/voice_engine/channel.cc
index 746db8114c600ab0d7afa7c0e2b4007d78b4b8da..d1c3a4bac69ec767a69f86ccb1745932f2b35a85 100644
--- a/webrtc/voice_engine/channel.cc
+++ b/webrtc/voice_engine/channel.cc
@@ -1784,11 +1784,7 @@ int32_t Channel::ReceivedRTCPPacket(const uint8_t* data, size_t length) {
UpdatePlayoutTimestamp(true);
// Deliver RTCP packet to RTP/RTCP module for parsing
- if (_rtpRtcpModule->IncomingRtcpPacket(data, length) == -1) {
- _engineStatisticsPtr->SetLastError(
- VE_SOCKET_TRANSPORT_MODULE_ERROR, kTraceWarning,
- "Channel::IncomingRTPPacket() RTCP packet is invalid");
- }
+ _rtpRtcpModule->IncomingRtcpPacket(data, length);
int64_t rtt = GetRTT(true);
if (rtt == 0) {

Powered by Google App Engine
This is Rietveld 408576698