webrtc/modules/rtp_rtcp/include/rtp_rtcp.h - Issue 3009403002: Drop return value from RtpRtcp::IncomingRtcpPacket.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/modules/rtp_rtcp/include/rtp_rtcp.h

Issue 3009403002: Drop return value from RtpRtcp::IncomingRtcpPacket. (Closed)

Patch Set: Delete VoENetworkTest.ReceivedRTCPPacketWithJunkDataShouldFail. Created 3 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: webrtc/modules/rtp_rtcp/include/rtp_rtcp.h

diff --git a/webrtc/modules/rtp_rtcp/include/rtp_rtcp.h b/webrtc/modules/rtp_rtcp/include/rtp_rtcp.h

index 25d904672a89820ab887dbf76bea9c7282c55294..4fb50d1bdef81ec185dbb705dd756eced3f2fdee 100644

--- a/webrtc/modules/rtp_rtcp/include/rtp_rtcp.h

+++ b/webrtc/modules/rtp_rtcp/include/rtp_rtcp.h

@@ -107,8 +107,8 @@ class RtpRtcp : public Module {

// Receiver functions

// **************************************************************************

- virtual int32_t IncomingRtcpPacket(const uint8_t* incoming_packet,

- size_t incoming_packet_length) = 0;

+ virtual void IncomingRtcpPacket(const uint8_t* incoming_packet,

+ size_t incoming_packet_length) = 0;

virtual void SetRemoteSSRC(uint32_t ssrc) = 0;