Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(891)

Side by Side Diff: webrtc/modules/rtp_rtcp/source/nack_rtx_unittest.cc

Issue 3009403002: Drop return value from RtpRtcp::IncomingRtcpPacket. (Closed)
Patch Set: Delete VoENetworkTest.ReceivedRTCPPacketWithJunkDataShouldFail. Created 3 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2013 The WebRTC project authors. All Rights Reserved. 2 * Copyright (c) 2013 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
(...skipping 134 matching lines...) Expand 10 before | Expand all | Expand 10 after
145 } 145 }
146 if (!rtp_receiver_->IncomingRtpPacket(header, ptr + header.headerLength, 146 if (!rtp_receiver_->IncomingRtpPacket(header, ptr + header.headerLength,
147 packet_length - header.headerLength, 147 packet_length - header.headerLength,
148 payload_specific, true)) { 148 payload_specific, true)) {
149 return false; 149 return false;
150 } 150 }
151 return true; 151 return true;
152 } 152 }
153 153
154 bool SendRtcp(const uint8_t* data, size_t len) override { 154 bool SendRtcp(const uint8_t* data, size_t len) override {
155 return module_->IncomingRtcpPacket((const uint8_t*)data, len) == 0; 155 module_->IncomingRtcpPacket((const uint8_t*)data, len);
156 return true;
156 } 157 }
157 int count_; 158 int count_;
158 int packet_loss_; 159 int packet_loss_;
159 int consecutive_drop_start_; 160 int consecutive_drop_start_;
160 int consecutive_drop_end_; 161 int consecutive_drop_end_;
161 uint32_t rtx_ssrc_; 162 uint32_t rtx_ssrc_;
162 int count_rtx_ssrc_; 163 int count_rtx_ssrc_;
163 RTPPayloadRegistry* rtp_payload_registry_; 164 RTPPayloadRegistry* rtp_payload_registry_;
164 RtpReceiver* rtp_receiver_; 165 RtpReceiver* rtp_receiver_;
165 RtpRtcp* module_; 166 RtpRtcp* module_;
(...skipping 168 matching lines...) Expand 10 before | Expand all | Expand 10 after
334 RunRtxTest(kRtxRetransmitted, 10); 335 RunRtxTest(kRtxRetransmitted, 10);
335 EXPECT_EQ(kTestSequenceNumber, *(receiver_.sequence_numbers_.begin())); 336 EXPECT_EQ(kTestSequenceNumber, *(receiver_.sequence_numbers_.begin()));
336 EXPECT_EQ(kTestSequenceNumber + kTestNumberOfPackets - 1, 337 EXPECT_EQ(kTestSequenceNumber + kTestNumberOfPackets - 1,
337 *(receiver_.sequence_numbers_.rbegin())); 338 *(receiver_.sequence_numbers_.rbegin()));
338 EXPECT_EQ(kTestNumberOfPackets, receiver_.sequence_numbers_.size()); 339 EXPECT_EQ(kTestNumberOfPackets, receiver_.sequence_numbers_.size());
339 EXPECT_EQ(kTestNumberOfRtxPackets, transport_.count_rtx_ssrc_); 340 EXPECT_EQ(kTestNumberOfRtxPackets, transport_.count_rtx_ssrc_);
340 EXPECT_TRUE(ExpectedPacketsReceived()); 341 EXPECT_TRUE(ExpectedPacketsReceived());
341 } 342 }
342 343
343 } // namespace webrtc 344 } // namespace webrtc
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698