Replace CHECK(x && y) with two separate CHECK() calls

Replace CHECK(x && y) with two separate CHECK() calls

That way, the debug printout will tell us which of x and y that was false.

BUG=none

Review-Url: https://codereview.webrtc.org/2988153003
Cr-Commit-Position: refs/heads/master@{#19297}
Committed: https://chromium.googlesource.com/external/webrtc/+/ee89e7870c332c943fb78faebc63e47d0a314d74

[kwiberg-webrtc, 2017-07-31 14:32:42]

The CQ bit was checked by kwiberg@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2017-07-31 14:32:54]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[kwiberg-webrtc, 2017-07-31 14:47:10]

kwiberg@webrtc.org changed reviewers:
+ mflodman@webrtc.org

[kwiberg-webrtc, 2017-07-31 14:47:10]

I was recently bit by this, and it wasn't too much work to simply fix all
occurrences in the tree.

[commit-bot: I haz the power, 2017-07-31 14:49:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-07-31 14:49:44]

Dry run: Try jobs failed on following builders:
  linux_more_configs on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/linux_more_configs/buil...)

[kwiberg-webrtc, 2017-07-31 15:17:15]

The CQ bit was checked by kwiberg@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2017-07-31 15:17:23]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-07-31 15:49:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-07-31 15:49:17]

Dry run: This issue passed the CQ dry run.

[kwiberg-webrtc, 2017-08-09 12:47:29]

Magnus, do you have time to review this, or should I find someone else? (There
are fewer people on vacation this week than last week when I posted this, I
think.)

[mflodman, 2017-08-09 12:51:46]

On 2017/08/09 12:47:29, kwiberg-webrtc wrote:
> Magnus, do you have time to review this, or should I find someone else? (There
> are fewer people on vacation this week than last week when I posted this, I
> think.)

Oh, I totally missed this last week in my post-vacation mess. I'll take a look
at it today!

[mflodman, 2017-08-09 15:27:07]

Two RTC_DCHECK_GE that should be RTC_DCHECK_GT, LGTM with that changed.

https://codereview.webrtc.org/2988153003/diff/20001/webrtc/modules/desktop_ca...
File webrtc/modules/desktop_capture/win/dxgi_texture_staging.cc (right):

https://codereview.webrtc.org/2988153003/diff/20001/webrtc/modules/desktop_ca...
webrtc/modules/desktop_capture/win/dxgi_texture_staging.cc:90:
RTC_DCHECK_GE(frame_info.AccumulatedFrames, 0);
Should be RTC_DCHECK_GT.

https://codereview.webrtc.org/2988153003/diff/20001/webrtc/rtc_base/opensslst...
File webrtc/rtc_base/opensslstreamadapter.cc (right):

https://codereview.webrtc.org/2988153003/diff/20001/webrtc/rtc_base/opensslst...
webrtc/rtc_base/opensslstreamadapter.cc:558: RTC_DCHECK_GE(code, 0);
RTC_DCHECK_GT

[kwiberg-webrtc, 2017-08-09 22:06:07]

Thanks a bunch for the careful read-through!

https://codereview.webrtc.org/2988153003/diff/20001/webrtc/modules/desktop_ca...
File webrtc/modules/desktop_capture/win/dxgi_texture_staging.cc (right):

https://codereview.webrtc.org/2988153003/diff/20001/webrtc/modules/desktop_ca...
webrtc/modules/desktop_capture/win/dxgi_texture_staging.cc:90:
RTC_DCHECK_GE(frame_info.AccumulatedFrames, 0);
On 2017/08/09 15:27:07, mflodman wrote:
> Should be RTC_DCHECK_GT.

Done.

https://codereview.webrtc.org/2988153003/diff/20001/webrtc/rtc_base/opensslst...
File webrtc/rtc_base/opensslstreamadapter.cc (right):

https://codereview.webrtc.org/2988153003/diff/20001/webrtc/rtc_base/opensslst...
webrtc/rtc_base/opensslstreamadapter.cc:558: RTC_DCHECK_GE(code, 0);
On 2017/08/09 15:27:07, mflodman wrote:
> RTC_DCHECK_GT

Done.

[kwiberg-webrtc, 2017-08-09 22:06:15]

The CQ bit was checked by kwiberg@webrtc.org

[kwiberg-webrtc, 2017-08-09 22:06:15]

The patchset sent to the CQ was uploaded after l-g-t-m from mflodman@webrtc.org
Link to the patchset: https://codereview.webrtc.org/2988153003/#ps60001 (title:
"fix mistakes")

[commit-bot: I haz the power, 2017-08-09 22:06:21]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-08-10 00:22:02]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1502316375417830,
"parent_rev": "608e94a03f02e718f16f2d5ec96d3ff0aa9fde2f", "commit_rev":
"ee89e7870c332c943fb78faebc63e47d0a314d74"}

[commit-bot: I haz the power, 2017-08-10 00:22:09]

Description was changed from

==========
Replace CHECK(x && y) with two separate CHECK() calls

That way, the debug printout will tell us which of x and y that was false.

BUG=none
==========

to

==========
Replace CHECK(x && y) with two separate CHECK() calls

That way, the debug printout will tell us which of x and y that was false.

BUG=none

Review-Url: https://codereview.webrtc.org/2988153003
Cr-Commit-Position: refs/heads/master@{#19297}
Committed:
https://chromium.googlesource.com/external/webrtc/+/ee89e7870c332c943fb78faeb...
==========

[commit-bot: I haz the power, 2017-08-10 00:22:10]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/external/webrtc/+/ee89e7870c332c943fb78faeb...