webrtc/pc/rtpreceiver.cc - Issue 2988153003: Replace CHECK(x && y) with two separate CHECK() calls

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/pc/rtpreceiver.cc

Issue 2988153003: Replace CHECK(x && y) with two separate CHECK() calls (Closed)

Patch Set: fix mistakes Created 3 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: webrtc/pc/rtpreceiver.cc

diff --git a/webrtc/pc/rtpreceiver.cc b/webrtc/pc/rtpreceiver.cc

index c6a2128dfb314ed5a450d217c2fb61e0b350845d..99c4010101b0636c80843ebc9fbdfb6f669e10ab 100644

--- a/webrtc/pc/rtpreceiver.cc

+++ b/webrtc/pc/rtpreceiver.cc

@@ -53,7 +53,8 @@ void AudioRtpReceiver::OnChanged() {

}

void AudioRtpReceiver::OnSetVolume(double volume) {

- RTC_DCHECK(volume >= 0 && volume <= 10);

+ RTC_DCHECK_GE(volume, 0);

+ RTC_DCHECK_LE(volume, 10);

cached_volume_ = volume;

if (!channel_) {

LOG(LS_ERROR) << "AudioRtpReceiver::OnSetVolume: No audio channel exists.";

« no previous file with comments | « webrtc/pc/remoteaudiosource.cc ('k') | webrtc/pc/rtpsender.cc » ('j') | no next file with comments »