Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(476)

Unified Diff: webrtc/modules/audio_device/dummy/file_audio_device_factory.cc

Issue 2988153003: Replace CHECK(x && y) with two separate CHECK() calls (Closed)
Patch Set: fix mistakes Created 3 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/modules/audio_device/dummy/file_audio_device_factory.cc
diff --git a/webrtc/modules/audio_device/dummy/file_audio_device_factory.cc b/webrtc/modules/audio_device/dummy/file_audio_device_factory.cc
index bce6be46339581df25674ff1be5fdd5b1a405f4c..9aeba205d94aead04c0df28225a31be9ee35f3f5 100644
--- a/webrtc/modules/audio_device/dummy/file_audio_device_factory.cc
+++ b/webrtc/modules/audio_device/dummy/file_audio_device_factory.cc
@@ -39,8 +39,8 @@ FileAudioDevice* FileAudioDeviceFactory::CreateFileAudioDevice(
void FileAudioDeviceFactory::SetFilenamesToUse(
const char* inputAudioFilename, const char* outputAudioFilename) {
#ifdef WEBRTC_DUMMY_FILE_DEVICES
- RTC_DCHECK(strlen(inputAudioFilename) < MAX_FILENAME_LEN &&
- strlen(outputAudioFilename) < MAX_FILENAME_LEN);
+ RTC_DCHECK_LT(strlen(inputAudioFilename), MAX_FILENAME_LEN);
+ RTC_DCHECK_LT(strlen(outputAudioFilename), MAX_FILENAME_LEN);
// Copy the strings since we don't know the lifetime of the input pointers.
strncpy(_inputAudioFilename, inputAudioFilename, MAX_FILENAME_LEN);

Powered by Google App Engine
This is Rietveld 408576698