webrtc/modules/desktop_capture/win/dxgi_texture_mapping.cc - Issue 2988153003: Replace CHECK(x && y) with two separate CHECK() calls

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/modules/desktop_capture/win/dxgi_texture_mapping.cc

Issue 2988153003: Replace CHECK(x && y) with two separate CHECK() calls (Closed)

Patch Set: fix mistakes Created 3 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: webrtc/modules/desktop_capture/win/dxgi_texture_mapping.cc

diff --git a/webrtc/modules/desktop_capture/win/dxgi_texture_mapping.cc b/webrtc/modules/desktop_capture/win/dxgi_texture_mapping.cc

index 90d8e896f1b0b17f59f0c800a52a116ab0fe3aa0..66e5e75812aa66a30ce38446f95cbb9ba3309c84 100644

--- a/webrtc/modules/desktop_capture/win/dxgi_texture_mapping.cc

+++ b/webrtc/modules/desktop_capture/win/dxgi_texture_mapping.cc

@@ -29,7 +29,8 @@ DxgiTextureMapping::~DxgiTextureMapping() = default;

bool DxgiTextureMapping::CopyFromTexture(

const DXGI_OUTDUPL_FRAME_INFO& frame_info,

ID3D11Texture2D* texture) {

- RTC_DCHECK(texture && frame_info.AccumulatedFrames > 0);

+ RTC_DCHECK_GT(frame_info.AccumulatedFrames, 0);

+ RTC_DCHECK(texture);

*rect() = {0};

_com_error error = duplication_->MapDesktopSurface(rect());

if (error.Error() != S_OK) {