webrtc/rtc_base/macutils.cc - Issue 2988153003: Replace CHECK(x && y) with two separate CHECK() calls

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/rtc_base/macutils.cc

Issue 2988153003: Replace CHECK(x && y) with two separate CHECK() calls (Closed)

Patch Set: fix mistakes Created 3 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: webrtc/rtc_base/macutils.cc

diff --git a/webrtc/rtc_base/macutils.cc b/webrtc/rtc_base/macutils.cc

index 282f7827a0c7518ba3524f08df004215fae73929..2e5e1fb36376fd14dcf72ad4edccf9c0a2331e18 100644

--- a/webrtc/rtc_base/macutils.cc

+++ b/webrtc/rtc_base/macutils.cc

@@ -72,7 +72,9 @@ void DecodeFourChar(UInt32 fc, std::string* out) {

}

static bool GetOSVersion(int* major, int* minor, int* bugfix) {

- RTC_DCHECK(major && minor && bugfix);

+ RTC_DCHECK(major);

+ RTC_DCHECK(minor);

+ RTC_DCHECK(bugfix);

struct utsname uname_info;

if (uname(&uname_info) != 0)

return false;