webrtc/p2p/client/basicportallocator.cc - Issue 2988153003: Replace CHECK(x && y) with two separate CHECK() calls

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/p2p/client/basicportallocator.cc

Issue 2988153003: Replace CHECK(x && y) with two separate CHECK() calls (Closed)

Patch Set: fix mistakes Created 3 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: webrtc/p2p/client/basicportallocator.cc

diff --git a/webrtc/p2p/client/basicportallocator.cc b/webrtc/p2p/client/basicportallocator.cc

index ce95895e8ac8544996edc39fd46fe989f08a1a2b..66ee9a4ecf09d0ab64afecc4e67d149987723646 100644

--- a/webrtc/p2p/client/basicportallocator.cc

+++ b/webrtc/p2p/client/basicportallocator.cc

@@ -1350,7 +1350,8 @@ void AllocationSequence::CreateRelayPorts() {

// If BasicPortAllocatorSession::OnAllocate left relay ports enabled then we

// ought to have a relay list for them here.

- RTC_DCHECK(config_ && !config_->relays.empty());

+ RTC_DCHECK(config_);

+ RTC_DCHECK(!config_->relays.empty());

if (!(config_ && !config_->relays.empty())) {

LOG(LS_WARNING)

<< "AllocationSequence: No relay server configured, skipping.";

« no previous file with comments | « webrtc/p2p/base/p2ptransportchannel_unittest.cc ('k') | webrtc/pc/datachannel.cc » ('j') | no next file with comments »