Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Issue 2984843003: MD Settings: Convert all usages of .bind(this) to use ES6 arrow function. (Closed)

Created:
3 years, 5 months ago by dpapad
Modified:
3 years, 5 months ago
Reviewers:
michaelpg
CC:
arv+watch_chromium.org, chromium-reviews, dcheng, gcasto+watchlist_chromium.org, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, stevenjb+watch-md-settings_chromium.org, tfarina, vabr+watchlistpasswordmanager_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

MD Settings: Convert all usages of .bind(this) to use ES6 arrow function. Conversion happened with an automated tool. After the conversion some new legitimate compiler errors surfaced, which I fixed. BUG=747596 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2984843003 Cr-Commit-Position: refs/heads/master@{#489075} Committed: https://chromium.googlesource.com/chromium/src/+/e535c2e3896a52940acf23e83d7505755fff5ea3

Patch Set 1 #

Patch Set 2 : Fix compiler errors, newly revealed. #

Total comments: 4

Patch Set 3 : Rebase #

Patch Set 4 : Resolve conflicts. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+367 lines, -395 lines) Patch
M chrome/browser/resources/settings/about_page/about_page.js View 1 chunk +6 lines, -6 lines 0 comments Download
M chrome/browser/resources/settings/about_page/about_page_browser_proxy.js View 1 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/resources/settings/about_page/channel_switcher_dialog.js View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/resources/settings/about_page/detailed_build_info.js View 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/resources/settings/animation/animation.js View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/resources/settings/appearance_page/appearance_page.js View 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/resources/settings/appearance_page/home_url_input.js View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/resources/settings/basic_page/basic_page.js View 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/resources/settings/bluetooth_page/bluetooth_device_dialog.js View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/resources/settings/bluetooth_page/bluetooth_subpage.js View 4 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/resources/settings/certificate_manager_page/ca_trust_edit_dialog.js View 2 chunks +8 lines, -11 lines 0 comments Download
M chrome/browser/resources/settings/certificate_manager_page/certificate_delete_confirmation_dialog.js View 2 chunks +6 lines, -8 lines 0 comments Download
M chrome/browser/resources/settings/certificate_manager_page/certificate_list.js View 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/browser/resources/settings/certificate_manager_page/certificate_manager_page.js View 3 chunks +8 lines, -8 lines 0 comments Download
M chrome/browser/resources/settings/certificate_manager_page/certificate_password_decryption_dialog.js View 1 chunk +4 lines, -5 lines 0 comments Download
M chrome/browser/resources/settings/certificate_manager_page/certificate_password_encryption_dialog.js View 1 chunk +4 lines, -5 lines 0 comments Download
M chrome/browser/resources/settings/certificate_manager_page/certificate_subentry.js View 1 chunk +3 lines, -5 lines 0 comments Download
M chrome/browser/resources/settings/clear_browsing_data_dialog/clear_browsing_data_browser_proxy.js View 1 1 chunk +4 lines, -2 lines 0 comments Download
M chrome/browser/resources/settings/clear_browsing_data_dialog/clear_browsing_data_dialog.js View 2 chunks +10 lines, -16 lines 0 comments Download
M chrome/browser/resources/settings/controls/pref_control_behavior.js View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/resources/settings/controls/settings_dropdown_menu.js View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/resources/settings/controls/settings_idle_load.js View 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/resources/settings/device_page/layout_behavior.js View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/resources/settings/device_page/storage.js View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/resources/settings/downloads_page/downloads_page.js View 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/browser/resources/settings/internet_page/internet_detail_page.js View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/resources/settings/internet_page/internet_known_networks_page.js View 5 chunks +8 lines, -10 lines 0 comments Download
M chrome/browser/resources/settings/internet_page/internet_page.js View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/resources/settings/internet_page/internet_subpage.js View 1 2 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/resources/settings/internet_page/network_apnlist.js View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/resources/settings/internet_page/network_nameservers.js View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/resources/settings/internet_page/network_property_list.js View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/resources/settings/internet_page/network_proxy.js View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/resources/settings/internet_page/network_siminfo.js View 8 chunks +8 lines, -8 lines 0 comments Download
M chrome/browser/resources/settings/internet_page/network_summary.js View 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/resources/settings/languages_page/add_languages_dialog.js View 1 2 3 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/resources/settings/languages_page/edit_dictionary_page.js View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/resources/settings/languages_page/languages.js View 4 chunks +16 lines, -20 lines 0 comments Download
M chrome/browser/resources/settings/languages_page/languages_page.js View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/resources/settings/on_startup_page/startup_url_dialog.js View 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/browser/resources/settings/on_startup_page/startup_urls_page.js View 1 chunk +8 lines, -8 lines 0 comments Download
M chrome/browser/resources/settings/passwords_and_forms_page/address_edit_dialog.js View 4 chunks +9 lines, -11 lines 0 comments Download
M chrome/browser/resources/settings/passwords_and_forms_page/autofill_section.js View 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/browser/resources/settings/passwords_and_forms_page/credit_card_edit_dialog.js View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/resources/settings/passwords_and_forms_page/passwords_section.js View 2 chunks +6 lines, -7 lines 0 comments Download
M chrome/browser/resources/settings/people_page/easy_unlock_turn_off_dialog.js View 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/browser/resources/settings/people_page/fingerprint_list.js View 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/resources/settings/people_page/import_data_dialog.js View 1 chunk +14 lines, -19 lines 0 comments Download
M chrome/browser/resources/settings/people_page/lock_screen.js View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/resources/settings/people_page/lock_state_behavior.js View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/resources/settings/people_page/manage_profile.js View 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/resources/settings/people_page/password_prompt_dialog.js View 3 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/resources/settings/people_page/people_page.js View 1 2 3 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/resources/settings/people_page/setup_fingerprint_dialog.js View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/resources/settings/people_page/sync_page.js View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/resources/settings/people_page/user_list.js View 1 chunk +6 lines, -6 lines 0 comments Download
M chrome/browser/resources/settings/people_page/users_page.js View 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/browser/resources/settings/prefs/prefs.js View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/resources/settings/printing_page/cups_add_printer_dialog.js View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/resources/settings/reset_page/reset_profile_dialog.js View 3 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/resources/settings/route.js View 2 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/resources/settings/search_engines_page/search_engine_dialog.js View 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/resources/settings/search_engines_page/search_engine_entry.js View 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/browser/resources/settings/search_engines_page/search_engines_page.js View 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/browser/resources/settings/search_page/search_page.js View 3 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/resources/settings/search_settings.js View 5 chunks +12 lines, -12 lines 0 comments Download
M chrome/browser/resources/settings/settings_main/settings_main.js View 4 chunks +10 lines, -10 lines 0 comments Download
M chrome/browser/resources/settings/settings_page/main_page_behavior.js View 5 chunks +18 lines, -18 lines 0 comments Download
M chrome/browser/resources/settings/settings_page/settings_section.js View 2 chunks +8 lines, -8 lines 0 comments Download
M chrome/browser/resources/settings/settings_ui/settings_ui.js View 4 chunks +12 lines, -12 lines 0 comments Download
M chrome/browser/resources/settings/site_settings/add_site_dialog.js View 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/resources/settings/site_settings/category_default_setting.js View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/resources/settings/site_settings/cookie_tree_behavior.js View 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/resources/settings/site_settings/edit_exception_dialog.js View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/resources/settings/site_settings/media_picker.js View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/resources/settings/site_settings/site_list.js View 2 chunks +6 lines, -7 lines 0 comments Download
M chrome/browser/resources/settings/site_settings/usb_devices.js View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/resources/settings/site_settings_page/site_settings_page.js View 2 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 20 (14 generated)
dpapad
Left comments at all the non-automated changes. https://codereview.chromium.org/2984843003/diff/20001/chrome/browser/resources/settings/about_page/about_page_browser_proxy.js File chrome/browser/resources/settings/about_page/about_page_browser_proxy.js (right): https://codereview.chromium.org/2984843003/diff/20001/chrome/browser/resources/settings/about_page/about_page_browser_proxy.js#newcode21 chrome/browser/resources/settings/about_page/about_page_browser_proxy.js:21: * currentChannel: ...
3 years, 5 months ago (2017-07-22 00:00:44 UTC) #11
dpapad
On 2017/07/22 at 00:00:44, dpapad wrote: > Left comments at all the non-automated changes. Also, ...
3 years, 5 months ago (2017-07-22 00:01:09 UTC) #12
michaelpg
lgtm! https://codereview.chromium.org/2984843003/diff/20001/chrome/browser/resources/settings/about_page/about_page_browser_proxy.js File chrome/browser/resources/settings/about_page/about_page_browser_proxy.js (right): https://codereview.chromium.org/2984843003/diff/20001/chrome/browser/resources/settings/about_page/about_page_browser_proxy.js#newcode21 chrome/browser/resources/settings/about_page/about_page_browser_proxy.js:21: * currentChannel: BrowserChannel, On 2017/07/22 00:00:43, dpapad wrote: ...
3 years, 5 months ago (2017-07-24 05:55:17 UTC) #13
dpapad
https://codereview.chromium.org/2984843003/diff/20001/chrome/browser/resources/settings/about_page/about_page_browser_proxy.js File chrome/browser/resources/settings/about_page/about_page_browser_proxy.js (right): https://codereview.chromium.org/2984843003/diff/20001/chrome/browser/resources/settings/about_page/about_page_browser_proxy.js#newcode21 chrome/browser/resources/settings/about_page/about_page_browser_proxy.js:21: * currentChannel: BrowserChannel, On 2017/07/24 at 05:55:17, michaelpg wrote: ...
3 years, 5 months ago (2017-07-24 17:56:50 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2984843003/60001
3 years, 5 months ago (2017-07-24 19:36:59 UTC) #17
commit-bot: I haz the power
3 years, 5 months ago (2017-07-24 21:12:40 UTC) #20
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/e535c2e3896a52940acf23e83d75...

Powered by Google App Engine
This is Rietveld 408576698