chrome/browser/resources/settings/internet_page/network_property_list.js - Issue 2984843003: MD Settings: Convert all usages of .bind(this) to use ES6 arrow function.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/settings/internet_page/network_property_list.js

Issue 2984843003: MD Settings: Convert all usages of .bind(this) to use ES6 arrow function. (Closed)

Patch Set: Resolve conflicts. Created 3 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/resources/settings/internet_page/network_nameservers.js ('k') | chrome/browser/resources/settings/internet_page/network_proxy.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/settings/internet_page/network_property_list.js

diff --git a/chrome/browser/resources/settings/internet_page/network_property_list.js b/chrome/browser/resources/settings/internet_page/network_property_list.js

index 006feca4d5ade7a673f982693481b38cd7d85b92..f333386cb780012619642ddb4b3501f62381c6e6 100644

--- a/chrome/browser/resources/settings/internet_page/network_property_list.js

+++ b/chrome/browser/resources/settings/internet_page/network_property_list.js

@@ -109,12 +109,12 @@ Polymer({

* @private

computeFilter_: function(prefix, propertyDict, editFieldTypes) {

- return function(key) {

+ return key => {

if (editFieldTypes.hasOwnProperty(key))

return true;

var value = this.getPropertyValue_(key, prefix, propertyDict);

return value !== undefined && value !== '';

- }.bind(this);

+ };

/**