Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(190)

Unified Diff: chrome/browser/resources/settings/basic_page/basic_page.js

Issue 2984843003: MD Settings: Convert all usages of .bind(this) to use ES6 arrow function. (Closed)
Patch Set: Resolve conflicts. Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/settings/basic_page/basic_page.js
diff --git a/chrome/browser/resources/settings/basic_page/basic_page.js b/chrome/browser/resources/settings/basic_page/basic_page.js
index d2c1e42107a74ccd36016b36fa190167ce9668f9..4f001f7530bbeeb75c6e2ba1dcb9f79aefed9080 100644
--- a/chrome/browser/resources/settings/basic_page/basic_page.js
+++ b/chrome/browser/resources/settings/basic_page/basic_page.js
@@ -99,9 +99,9 @@ Polymer({
attached: function() {
this.currentRoute_ = settings.getCurrentRoute();
- this.addEventListener('chrome-cleanup-dismissed', function(e) {
+ this.addEventListener('chrome-cleanup-dismissed', e => {
this.showChromeCleanup = false;
- }.bind(this));
+ });
if (settings.AndroidAppsBrowserProxyImpl) {
cr.addWebUIListener(
@@ -247,9 +247,9 @@ Polymer({
*/
advancedToggleExpandedChanged_: function() {
if (this.advancedToggleExpanded) {
- this.async(function() {
+ this.async(() => {
this.$$('#advancedPageTemplate').get();
- }.bind(this));
+ });
}
},

Powered by Google App Engine
This is Rietveld 408576698