chrome/browser/resources/settings/certificate_manager_page/certificate_subentry.js - Issue 2984843003: MD Settings: Convert all usages of .bind(this) to use ES6 arrow function.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/settings/certificate_manager_page/certificate_subentry.js

Issue 2984843003: MD Settings: Convert all usages of .bind(this) to use ES6 arrow function. (Closed)

Patch Set: Resolve conflicts. Created 3 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/resources/settings/certificate_manager_page/certificate_password_encryption_dialog.js ('k') | chrome/browser/resources/settings/clear_browsing_data_dialog/clear_browsing_data_browser_proxy.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/settings/certificate_manager_page/certificate_subentry.js

diff --git a/chrome/browser/resources/settings/certificate_manager_page/certificate_subentry.js b/chrome/browser/resources/settings/certificate_manager_page/certificate_subentry.js

index 9c858be8b982beedb88fb47889af582dccdd2caa..fafc458a0b0688ea54bcf52cd55393f2960bcb5d 100644

--- a/chrome/browser/resources/settings/certificate_manager_page/certificate_subentry.js

+++ b/chrome/browser/resources/settings/certificate_manager_page/certificate_subentry.js

@@ -107,11 +107,9 @@ Polymer({

onExportTap_: function(event) {

this.closePopupMenu_();

if (this.certificateType == CertificateType.PERSONAL) {

- this.browserProxy_.exportPersonalCertificate(this.model.id)

- .then(function() {

- this.dispatchCertificateActionEvent_(

- CertificateAction.EXPORT_PERSONAL);

- }.bind(this), this.onRejected_.bind(this));

+ this.browserProxy_.exportPersonalCertificate(this.model.id).then(() => {

+ this.dispatchCertificateActionEvent_(CertificateAction.EXPORT_PERSONAL);

+ }, this.onRejected_.bind(this));

} else {

this.browserProxy_.exportCertificate(this.model.id);

}