Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(356)

Unified Diff: chrome/browser/resources/settings/internet_page/internet_known_networks_page.js

Issue 2984843003: MD Settings: Convert all usages of .bind(this) to use ES6 arrow function. (Closed)
Patch Set: Resolve conflicts. Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/settings/internet_page/internet_known_networks_page.js
diff --git a/chrome/browser/resources/settings/internet_page/internet_known_networks_page.js b/chrome/browser/resources/settings/internet_page/internet_known_networks_page.js
index 791bf1107f46cc4e246827c0eceb52bb3e6d5218..f1254442cbfefc6c9c01fb30f5b4ac305274d48d 100644
--- a/chrome/browser/resources/settings/internet_page/internet_known_networks_page.js
+++ b/chrome/browser/resources/settings/internet_page/internet_known_networks_page.js
@@ -96,9 +96,9 @@ Polymer({
visible: false,
configured: true
};
- this.networkingPrivate.getNetworks(filter, function(states) {
+ this.networkingPrivate.getNetworks(filter, states => {
this.networkStateList_ = states;
- }.bind(this));
+ });
},
/**
@@ -125,9 +125,8 @@ Polymer({
* @private
*/
havePreferred_: function() {
- return this.networkStateList_.find(function(state) {
- return this.networkIsPreferred_(state);
- }.bind(this)) !== undefined;
+ return this.networkStateList_.find(
+ state => this.networkIsPreferred_(state)) !== undefined;
},
/**
@@ -135,9 +134,8 @@ Polymer({
* @private
*/
haveNotPreferred_: function() {
- return this.networkStateList_.find(function(state) {
- return this.networkIsNotPreferred_(state);
- }.bind(this)) !== undefined;
+ return this.networkStateList_.find(
+ state => this.networkIsNotPreferred_(state)) !== undefined;
},
/**
@@ -153,7 +151,7 @@ Polymer({
// properties for the network. The delay is not noticeable (~5ms) and is
// preferable to initiating a query for every known network at load time.
this.networkingPrivate.getManagedProperties(
- this.selectedGuid_, function(properties) {
+ this.selectedGuid_, properties => {
if (chrome.runtime.lastError || !properties) {
this.showAddPreferred_ = false;
this.showRemovePreferred_ = false;
@@ -168,7 +166,7 @@ Polymer({
this.showRemovePreferred_ = preferred;
}
/** @type {!CrActionMenuElement} */ (this.$.dotsMenu).showAt(button);
- }.bind(this));
+ });
event.stopPropagation();
},

Powered by Google App Engine
This is Rietveld 408576698