chrome/browser/resources/settings/search_engines_page/search_engine_dialog.js - Issue 2984843003: MD Settings: Convert all usages of .bind(this) to use ES6 arrow function.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/settings/search_engines_page/search_engine_dialog.js

Issue 2984843003: MD Settings: Convert all usages of .bind(this) to use ES6 arrow function. (Closed)

Patch Set: Resolve conflicts. Created 3 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/resources/settings/route.js ('k') | chrome/browser/resources/settings/search_engines_page/search_engine_entry.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/settings/search_engines_page/search_engine_dialog.js

diff --git a/chrome/browser/resources/settings/search_engines_page/search_engine_dialog.js b/chrome/browser/resources/settings/search_engines_page/search_engine_dialog.js

index f77d20022fe00a9c64a390600f5abda07db7d211..465bfa25f340e00501caa9d2dbbe403359847ea3 100644

--- a/chrome/browser/resources/settings/search_engines_page/search_engine_dialog.js

+++ b/chrome/browser/resources/settings/search_engines_page/search_engine_dialog.js

@@ -66,9 +66,9 @@ Polymer({

this.actionButtonText_ = loadTimeData.getString('add');

}

- this.addEventListener('cancel', function() {

+ this.addEventListener('cancel', () => {

this.browserProxy_.searchEngineEditCancelled();

- }.bind(this));

+ });

/** @override */

@@ -108,10 +108,10 @@ Polymer({

this.browserProxy_

.validateSearchEngineInput(inputElement.id, inputElement.value)

- .then(function(isValid) {

+ .then(isValid => {

inputElement.invalid = !isValid;

this.updateActionButtonState_();

- }.bind(this));

+ });

/** @private */