Partial Reland of Make the default ctor of rtc::Thread, protected

Reland of Make the default ctor of rtc::Thread, protected

This is a partial re-land. The change doesn't make the default Thread ctor protected anymore but it does mark it as deprecated and updates all use of it in WebRTC.

Original issue's description:

Make the default ctor of rtc::Thread, protected.
The goal is to force use of Thread::Create or Thread::CreateWithSocketServer.

The default constructor constructs a 'default' socket server, which is usually a 'physical' socket server, but not always. Not every instance of Thread actually needs to have network support, so it's better to have this be explicit instead of unknowingly instantiate one.

BUG=none

Review-Url: https://codereview.webrtc.org/2977953002
Cr-Commit-Position: refs/heads/master@{#19031}
Committed: https://chromium.googlesource.com/external/webrtc/+/e7251599a37051f07d81cb8333823f550eae5b9c

[tommi, 2017-07-14 10:24:03]

Created Reland of Make the default ctor of rtc::Thread, protected

[tommi, 2017-07-14 10:26:05]

Description was changed from

==========
Reland of Make the default ctor of rtc::Thread, protected (patchset #1 id:1 of
https://codereview.webrtc.org/2979963002/ )

Reason for revert:
Preparing partial re-land. Won't make the ctor protected but will mark it as
deprecated and keep all other changes.

Original issue's description:
> Revert of Make the default ctor of rtc::Thread, protected (patchset #3
id:40001 of https://codereview.webrtc.org/2981623002/ )
> 
> Reason for revert:
> Break projects.
> 
> Original issue's description:
> > Make the default ctor of rtc::Thread, protected.
> > The goal is to force use of Thread::Create or
Thread::CreateWithSocketServer.
> > 
> > The default constructor constructs a 'default' socket server, which is
usually a 'physical' socket server, but not always. Not every instance of Thread
actually needs to have network support, so it's better to have this be explicit
instead of unknowingly instantiate one.
> > 
> > BUG=none
> > 
> > Review-Url: https://codereview.webrtc.org/2981623002
> > Cr-Commit-Position: refs/heads/master@{#19001}
> > Committed:
https://chromium.googlesource.com/external/webrtc/+/a8a351599788f346a2265cfcd...
> 
> TBR=kthelgason@webrtc.org,tommi@webrtc.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=none
> 
> Review-Url: https://codereview.webrtc.org/2979963002
> Cr-Commit-Position: refs/heads/master@{#19003}
> Committed:
https://chromium.googlesource.com/external/webrtc/+/a117b04113f8e6f6684e050b8...

TBR=kthelgason@webrtc.org,charujain@webrtc.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=none
==========

to

==========
Reland of Make the default ctor of rtc::Thread, protected

This is a partial re-land. The change doesn't make the default Thread ctor
protected anymore but it does mark it as deprecated and updates all use of it in
WebRTC.

Original issue's description:

Make the default ctor of rtc::Thread, protected.
The goal is to force use of Thread::Create or Thread::CreateWithSocketServer.

The default constructor constructs a 'default' socket server, which is usually a
'physical' socket server, but not always. Not every instance of Thread actually
needs to have network support, so it's better to have this be explicit instead
of unknowingly instantiate one.

BUG=none
==========

[tommi, 2017-07-14 12:38:04]

Update use of default ctor and make the ctor public again (with note)

[tommi, 2017-07-14 12:38:12]

The CQ bit was checked by tommi@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2017-07-14 12:38:20]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[tommi, 2017-07-14 12:48:59]

Kári - can you take a look again?  It's basically the same thing as before but I
made the default ctor public again, documented it as deprecated and updated the
following files to not depend on it:

webrtc/rtc_base/logging_unittest.cc
webrtc/rtc_base/thread.cc
webrtc/rtc_base/thread_checker_unittest.cc
webrtc/rtc_base/thread_unittest.cc

The rest is the same as it was before - rebasing.

[kthelgason, 2017-07-14 12:50:56]

On 2017/07/14 12:48:59, tommi (wëbrtc) wrote:
> Kári - can you take a look again?  It's basically the same thing as before but
I
> made the default ctor public again, documented it as deprecated and updated
the
> following files to not depend on it:
> 
> webrtc/rtc_base/logging_unittest.cc
> webrtc/rtc_base/thread.cc
> webrtc/rtc_base/thread_checker_unittest.cc
> webrtc/rtc_base/thread_unittest.cc
> 
> The rest is the same as it was before - rebasing.

lgtm. Do you plan on fixing whatever internal projects broke from making the
ctor private and relanding that part?

[commit-bot: I haz the power, 2017-07-14 13:10:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-07-14 13:10:33]

Dry run: Try jobs failed on following builders:
  linux_asan on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/linux_asan/builds/26372)

[tommi, 2017-07-14 14:50:44]

The CQ bit was checked by tommi@webrtc.org

[commit-bot: I haz the power, 2017-07-14 14:50:51]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-07-14 15:06:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-07-14 15:06:22]

Try jobs failed on following builders:
  linux_asan on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/linux_asan/builds/26380)

[tommi, 2017-07-14 20:42:53]

Add tests for correct deletion of the thread checker in
DestructorAllowedOnDifferentThread

[tommi, 2017-07-14 20:58:20]

sigh, misread the error. fixed.

[tommi, 2017-07-14 20:58:38]

The CQ bit was checked by tommi@webrtc.org

[tommi, 2017-07-14 20:58:38]

The patchset sent to the CQ was uploaded after l-g-t-m from
kthelgason@webrtc.org
Link to the patchset: https://codereview.webrtc.org/2977953002/#ps370001 (title:
"sigh, misread the error. fixed.")

[commit-bot: I haz the power, 2017-07-14 20:58:41]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[tommi, 2017-07-14 21:01:12]

The CQ bit was unchecked by tommi@webrtc.org

[tommi, 2017-07-14 21:05:31]

Fix the same error elsewhere

[tommi, 2017-07-14 21:05:41]

The CQ bit was checked by tommi@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2017-07-14 21:05:50]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-07-14 21:39:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-07-14 21:39:02]

Dry run: This issue passed the CQ dry run.

[tommi, 2017-07-14 21:41:34]

The CQ bit was checked by tommi@webrtc.org

[tommi, 2017-07-14 21:41:35]

The patchset sent to the CQ was uploaded after l-g-t-m from
kthelgason@webrtc.org
Link to the patchset: https://codereview.webrtc.org/2977953002/#ps390001 (title:
"Fix the same error elsewhere")

[commit-bot: I haz the power, 2017-07-14 21:41:41]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-07-14 21:44:46]

CQ is committing da patch.

Bot data: {"patchset_id": 390001, "attempt_start_ts": 1500068494810120,
"parent_rev": "bc266bc867354136bf14df0ccae5a58c9226a98d", "commit_rev":
"e7251599a37051f07d81cb8333823f550eae5b9c"}

[commit-bot: I haz the power, 2017-07-14 21:44:53]

Description was changed from

==========
Reland of Make the default ctor of rtc::Thread, protected

This is a partial re-land. The change doesn't make the default Thread ctor
protected anymore but it does mark it as deprecated and updates all use of it in
WebRTC.

Original issue's description:

Make the default ctor of rtc::Thread, protected.
The goal is to force use of Thread::Create or Thread::CreateWithSocketServer.

The default constructor constructs a 'default' socket server, which is usually a
'physical' socket server, but not always. Not every instance of Thread actually
needs to have network support, so it's better to have this be explicit instead
of unknowingly instantiate one.

BUG=none
==========

to

==========
Reland of Make the default ctor of rtc::Thread, protected

This is a partial re-land. The change doesn't make the default Thread ctor
protected anymore but it does mark it as deprecated and updates all use of it in
WebRTC.

Original issue's description:

Make the default ctor of rtc::Thread, protected.
The goal is to force use of Thread::Create or Thread::CreateWithSocketServer.

The default constructor constructs a 'default' socket server, which is usually a
'physical' socket server, but not always. Not every instance of Thread actually
needs to have network support, so it's better to have this be explicit instead
of unknowingly instantiate one.

BUG=none

Review-Url: https://codereview.webrtc.org/2977953002
Cr-Commit-Position: refs/heads/master@{#19031}
Committed:
https://chromium.googlesource.com/external/webrtc/+/e7251599a37051f07d81cb833...
==========

[commit-bot: I haz the power, 2017-07-14 21:44:54]

Committed patchset #5 (id:390001) as
https://chromium.googlesource.com/external/webrtc/+/e7251599a37051f07d81cb833...