Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(224)

Issue 2979963002: Revert of Make the default ctor of rtc::Thread, protected (Closed)

Created:
3 years, 5 months ago by charujain
Modified:
3 years, 5 months ago
Reviewers:
tommi, kthelgason
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of Make the default ctor of rtc::Thread, protected (patchset #3 id:40001 of https://codereview.webrtc.org/2981623002/ ) Reason for revert: Break projects. Original issue's description: > Make the default ctor of rtc::Thread, protected. > The goal is to force use of Thread::Create or Thread::CreateWithSocketServer. > > The default constructor constructs a 'default' socket server, which is usually a 'physical' socket server, but not always. Not every instance of Thread actually needs to have network support, so it's better to have this be explicit instead of unknowingly instantiate one. > > BUG=none > > Review-Url: https://codereview.webrtc.org/2981623002 > Cr-Commit-Position: refs/heads/master@{#19001} > Committed: https://chromium.googlesource.com/external/webrtc/+/a8a351599788f346a2265cfcd3da9a06f577de7f TBR=kthelgason@webrtc.org,tommi@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=none Review-Url: https://codereview.webrtc.org/2979963002 Cr-Commit-Position: refs/heads/master@{#19003} Committed: https://chromium.googlesource.com/external/webrtc/+/a117b04113f8e6f6684e050b8a3a54b44e74672a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+145 lines, -153 lines) Patch
M webrtc/pc/channelmanager_unittest.cc View 4 chunks +15 lines, -17 lines 0 comments Download
M webrtc/pc/peerconnectionendtoend_unittest.cc View 2 chunks +6 lines, -8 lines 0 comments Download
M webrtc/pc/peerconnectioninterface_unittest.cc View 1 chunk +4 lines, -5 lines 0 comments Download
M webrtc/pc/proxy_unittest.cc View 3 chunks +14 lines, -16 lines 0 comments Download
M webrtc/pc/rtcstats_integrationtest.cc View 2 chunks +7 lines, -8 lines 0 comments Download
M webrtc/pc/test/fakeaudiocapturemodule.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/rtc_base/criticalsection_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/rtc_base/messagequeue_unittest.cc View 8 chunks +22 lines, -22 lines 0 comments Download
M webrtc/rtc_base/nullsocketserver_unittest.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M webrtc/rtc_base/physicalsocketserver_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/rtc_base/rtccertificategenerator_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/rtc_base/socket_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/rtc_base/thread.h View 1 chunk +2 lines, -3 lines 0 comments Download
M webrtc/rtc_base/thread_unittest.cc View 12 chunks +44 lines, -42 lines 0 comments Download
M webrtc/rtc_base/timeutils_unittest.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M webrtc/sdk/android/src/jni/androidmediadecoder_jni.cc View 2 chunks +19 lines, -20 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
charujain
Created Revert of Make the default ctor of rtc::Thread, protected
3 years, 5 months ago (2017-07-13 14:06:23 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2979963002/1
3 years, 5 months ago (2017-07-13 14:06:31 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/external/webrtc/+/a117b04113f8e6f6684e050b8a3a54b44e74672a
3 years, 5 months ago (2017-07-13 14:06:45 UTC) #6
tommi
3 years, 5 months ago (2017-07-14 10:24:02 UTC) #7
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.webrtc.org/2977953002/ by tommi@webrtc.org.

The reason for reverting is: Preparing partial re-land. Won't make the ctor
protected but will mark it as deprecated and keep all other changes..

Powered by Google App Engine
This is Rietveld 408576698