Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1526)

Unified Diff: webrtc/pc/channelmanager_unittest.cc

Issue 2979963002: Revert of Make the default ctor of rtc::Thread, protected (Closed)
Patch Set: Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | webrtc/pc/peerconnectionendtoend_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/pc/channelmanager_unittest.cc
diff --git a/webrtc/pc/channelmanager_unittest.cc b/webrtc/pc/channelmanager_unittest.cc
index b322407b4645da51104088fb63a33938cb1a62ed..c03056c637abfcc47a25e740f58e1cb6cd822076 100644
--- a/webrtc/pc/channelmanager_unittest.cc
+++ b/webrtc/pc/channelmanager_unittest.cc
@@ -38,9 +38,7 @@
class ChannelManagerTest : public testing::Test {
protected:
ChannelManagerTest()
- : network_(rtc::Thread::CreateWithSocketServer()),
- worker_(rtc::Thread::Create()),
- fme_(new cricket::FakeMediaEngine()),
+ : fme_(new cricket::FakeMediaEngine()),
fdme_(new cricket::FakeDataEngine()),
cm_(new cricket::ChannelManager(
std::unique_ptr<MediaEngineInterface>(fme_),
@@ -54,8 +52,8 @@
}
webrtc::RtcEventLogNullImpl event_log_;
- std::unique_ptr<rtc::Thread> network_;
- std::unique_ptr<rtc::Thread> worker_;
+ rtc::Thread network_;
+ rtc::Thread worker_;
// |fme_| and |fdme_| are actually owned by |cm_|.
cricket::FakeMediaEngine* fme_;
cricket::FakeDataEngine* fdme_;
@@ -76,14 +74,14 @@
// Test that we startup/shutdown properly with a worker thread.
TEST_F(ChannelManagerTest, StartupShutdownOnThread) {
- network_->Start();
- worker_->Start();
+ network_.Start();
+ worker_.Start();
EXPECT_FALSE(cm_->initialized());
EXPECT_EQ(rtc::Thread::Current(), cm_->worker_thread());
- EXPECT_TRUE(cm_->set_network_thread(network_.get()));
- EXPECT_EQ(network_.get(), cm_->network_thread());
- EXPECT_TRUE(cm_->set_worker_thread(worker_.get()));
- EXPECT_EQ(worker_.get(), cm_->worker_thread());
+ EXPECT_TRUE(cm_->set_network_thread(&network_));
+ EXPECT_EQ(&network_, cm_->network_thread());
+ EXPECT_TRUE(cm_->set_worker_thread(&worker_));
+ EXPECT_EQ(&worker_, cm_->worker_thread());
EXPECT_TRUE(cm_->Init());
EXPECT_TRUE(cm_->initialized());
// Setting the network or worker thread while initialized should fail.
@@ -123,13 +121,13 @@
// Test that we can create and destroy a voice and video channel with a worker.
TEST_F(ChannelManagerTest, CreateDestroyChannelsOnThread) {
- network_->Start();
- worker_->Start();
- EXPECT_TRUE(cm_->set_worker_thread(worker_.get()));
- EXPECT_TRUE(cm_->set_network_thread(network_.get()));
+ network_.Start();
+ worker_.Start();
+ EXPECT_TRUE(cm_->set_worker_thread(&worker_));
+ EXPECT_TRUE(cm_->set_network_thread(&network_));
EXPECT_TRUE(cm_->Init());
- transport_controller_.reset(new cricket::FakeTransportController(
- network_.get(), ICEROLE_CONTROLLING));
+ transport_controller_.reset(
+ new cricket::FakeTransportController(&network_, ICEROLE_CONTROLLING));
cricket::DtlsTransportInternal* rtp_transport =
transport_controller_->CreateDtlsTransport(
cricket::CN_AUDIO, cricket::ICE_CANDIDATE_COMPONENT_RTP);
« no previous file with comments | « no previous file | webrtc/pc/peerconnectionendtoend_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698