Partial Reland of Make the default ctor of rtc::Thread, protected

webrtc/rtc_base/timeutils_unittest.cc

 /*
  *  Copyright 2004 The WebRTC Project Authors. All rights reserved.
  *
  *  Use of this source code is governed by a BSD-style license
  *  that can be found in the LICENSE file in the root of the source
  *  tree. An additional intellectual property rights grant can be found
  *  in the file PATENTS.  All contributing project authors may
  *  be found in the AUTHORS file in the root of the source tree.
  */
 
@@ skipping 331 matching lines @@
 // When the clock is advanced, threads that are waiting in a socket select
 // should wake up and look at the new time. This allows tests using the
 // fake clock to run much faster, if the test is bound by time constraints
 // (such as a test for a STUN ping timeout).
 TEST(FakeClock, SettingTimeWakesThreads) {
   int64_t real_start_time_ms = TimeMillis();
 
   FakeClock clock;
   SetClockForTesting(&clock);
 
-  Thread worker;
-  worker.Start();
+  std::unique_ptr<Thread> worker(Thread::CreateWithSocketServer());
+  worker->Start();
 
   // Post an event that won't be executed for 10 seconds.
   Event message_handler_dispatched(false, false);
   auto functor = [&message_handler_dispatched] {
     message_handler_dispatched.Set();
   };
   FunctorMessageHandler<void, decltype(functor)> handler(functor);
-  worker.PostDelayed(RTC_FROM_HERE, 60000, &handler);
+  worker->PostDelayed(RTC_FROM_HERE, 60000, &handler);
 
   // Wait for a bit for the worker thread to be started and enter its socket
   // select(). Otherwise this test would be trivial since the worker thread
   // would process the event as soon as it was started.
   Thread::Current()->SleepMs(1000);
 
   // Advance the fake clock, expecting the worker thread to wake up
   // and dispatch the message instantly.
   clock.AdvanceTime(TimeDelta::FromSeconds(60u));
   EXPECT_TRUE(message_handler_dispatched.Wait(0));
-  worker.Stop();
+  worker->Stop();
 
   SetClockForTesting(nullptr);
 
   // The message should have been dispatched long before the 60 seconds fully
   // elapsed (just a sanity check).
   int64_t real_end_time_ms = TimeMillis();
   EXPECT_LT(real_end_time_ms - real_start_time_ms, 10000);
 }
 
 }  // namespace rtc