webrtc/rtc_base/nullsocketserver_unittest.cc - Issue 2977953002: Partial Reland of Make the default ctor of rtc::Thread, protected

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/rtc_base/nullsocketserver_unittest.cc

Issue 2977953002: Partial Reland of Make the default ctor of rtc::Thread, protected (Closed)

Patch Set: Fix the same error elsewhere Created 3 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: webrtc/rtc_base/nullsocketserver_unittest.cc

diff --git a/webrtc/rtc_base/nullsocketserver_unittest.cc b/webrtc/rtc_base/nullsocketserver_unittest.cc

index 5908d32958a6d93d296ef7617ff73fc938343935..5538322643a387dc73c676193ee3f7221cf34718 100644

--- a/webrtc/rtc_base/nullsocketserver_unittest.cc

+++ b/webrtc/rtc_base/nullsocketserver_unittest.cc

@@ -28,9 +28,9 @@ class NullSocketServerTest

};

TEST_F(NullSocketServerTest, WaitAndSet) {

- Thread thread;

- EXPECT_TRUE(thread.Start());

- thread.Post(RTC_FROM_HERE, this, 0);

+ auto thread = Thread::Create();

+ EXPECT_TRUE(thread->Start());

+ thread->Post(RTC_FROM_HERE, this, 0);

// The process_io will be ignored.

const bool process_io = true;

EXPECT_TRUE_WAIT(ss_.Wait(SocketServer::kForever, process_io), kTimeout);