Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(950)

Unified Diff: webrtc/rtc_base/thread.h

Issue 2977953002: Partial Reland of Make the default ctor of rtc::Thread, protected (Closed)
Patch Set: Fix the same error elsewhere Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webrtc/rtc_base/socket_unittest.cc ('k') | webrtc/rtc_base/thread.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/rtc_base/thread.h
diff --git a/webrtc/rtc_base/thread.h b/webrtc/rtc_base/thread.h
index 35b28eac5392593aadb799e62a8b803987fb4a87..f037d8a7ac1ff6433bb4a79caf8b65a6a9731e04 100644
--- a/webrtc/rtc_base/thread.h
+++ b/webrtc/rtc_base/thread.h
@@ -102,8 +102,13 @@ class Runnable {
class LOCKABLE Thread : public MessageQueue {
public:
- // Create a new Thread and optionally assign it to the passed SocketServer.
+ // DEPRECATED.
+ // The default constructor should not be used because it hides whether or
+ // not a socket server will be associated with the thread. Most instances
+ // of Thread do actually not need one, so please use either of the Create*
+ // methods to construct an instance of Thread.
Thread();
+
explicit Thread(SocketServer* ss);
explicit Thread(std::unique_ptr<SocketServer> ss);
« no previous file with comments | « webrtc/rtc_base/socket_unittest.cc ('k') | webrtc/rtc_base/thread.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698