Reland of PyLint fixes for tools-webrtc and webrtc/tools

Reland of PyLint fixes for tools-webrtc and webrtc/tools (patchset #1 id:1 of https://codereview.webrtc.org/2737233003/ )

Reason for revert:
Fixing errors for reland. I have tested that this does not make Chromium video quality tests fail.

Original issue's description:
> Revert of PyLint fixes for tools-webrtc and webrtc/tools (patchset #3 id:40001 of https://codereview.webrtc.org/2736233003/ )
> 
> Reason for revert:
> Fails video quality tests in Chrome:  http://build.chromium.org/p/chromium.webrtc.fyi/builders/Win10%20Tester/builds/6568
> I should have looked more closer at those :(
> 
> Original issue's description:
> > PyLint fixes for tools-webrtc and webrtc/tools
> > 
> > Fix a lot of errors before bringing in the new config in
> > https://codereview.webrtc.org/2737963003/
> > 
> > BUG=webrtc:7303
> > NOTRY=True
> > 
> > Review-Url: https://codereview.webrtc.org/2736233003
> > Cr-Commit-Position: refs/heads/master@{#17137}
> > Committed: https://chromium.googlesource.com/external/webrtc/+/f5318e1f391859c82aaa47b297429e50f41f6b3c
> 
> TBR=oprypin@webrtc.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=webrtc:7303
> 
> Review-Url: https://codereview.webrtc.org/2737233003
> Cr-Commit-Position: refs/heads/master@{#17142}
> Committed: https://chromium.googlesource.com/external/webrtc/+/94f4d9effc3fa1ee6a6a48a7bbdef6684defd1dc

NOTRY=true
BUG=webrtc:7312
Review-Url: https://codereview.webrtc.org/2741733003
Cr-Commit-Position: refs/heads/master@{#17541}
Committed: https://chromium.googlesource.com/external/webrtc/+/c88b5d56ada5690ae352062e69a9f984a07d228c

[kjellander_webrtc, 2017-03-09 14:34:16]

Created Reland of PyLint fixes for tools-webrtc and webrtc/tools

[kjellander_webrtc, 2017-03-09 14:53:07]

Fixes are now in PS#2, but I will do manual tests tomorrow before submitting.

[kjellander_webrtc, 2017-03-09 14:53:29]

Description was changed from

==========
Reland of PyLint fixes for tools-webrtc and webrtc/tools (patchset #1 id:1 of
https://codereview.webrtc.org/2737233003/ )

Reason for revert:
Fixing errors for reland

Original issue's description:
> Revert of PyLint fixes for tools-webrtc and webrtc/tools (patchset #3 id:40001
of https://codereview.webrtc.org/2736233003/ )
> 
> Reason for revert:
> Fails video quality tests in Chrome: 
http://build.chromium.org/p/chromium.webrtc.fyi/builders/Win10%20Tester/build...
> I should have looked more closer at those :(
> 
> Original issue's description:
> > PyLint fixes for tools-webrtc and webrtc/tools
> > 
> > Fix a lot of errors before bringing in the new config in
> > https://codereview.webrtc.org/2737963003/
> > 
> > BUG=webrtc:7303
> > NOTRY=True
> > 
> > Review-Url: https://codereview.webrtc.org/2736233003
> > Cr-Commit-Position: refs/heads/master@{#17137}
> > Committed:
https://chromium.googlesource.com/external/webrtc/+/f5318e1f391859c82aaa47b29...
> 
> TBR=oprypin@webrtc.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=webrtc:7303
> 
> Review-Url: https://codereview.webrtc.org/2737233003
> Cr-Commit-Position: refs/heads/master@{#17142}
> Committed:
https://chromium.googlesource.com/external/webrtc/+/94f4d9effc3fa1ee6a6a48a7b...

TBR=oprypin@webrtc.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=webrtc:7303
==========

to

==========
Reland of PyLint fixes for tools-webrtc and webrtc/tools (patchset #1 id:1 of
https://codereview.webrtc.org/2737233003/ )

Reason for revert:
Fixing errors for reland

Original issue's description:
> Revert of PyLint fixes for tools-webrtc and webrtc/tools (patchset #3 id:40001
of https://codereview.webrtc.org/2736233003/ )
> 
> Reason for revert:
> Fails video quality tests in Chrome: 
http://build.chromium.org/p/chromium.webrtc.fyi/builders/Win10%20Tester/build...
> I should have looked more closer at those :(
> 
> Original issue's description:
> > PyLint fixes for tools-webrtc and webrtc/tools
> > 
> > Fix a lot of errors before bringing in the new config in
> > https://codereview.webrtc.org/2737963003/
> > 
> > BUG=webrtc:7303
> > NOTRY=True
> > 
> > Review-Url: https://codereview.webrtc.org/2736233003
> > Cr-Commit-Position: refs/heads/master@{#17137}
> > Committed:
https://chromium.googlesource.com/external/webrtc/+/f5318e1f391859c82aaa47b29...
> 
> TBR=oprypin@webrtc.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=webrtc:7303
> 
> Review-Url: https://codereview.webrtc.org/2737233003
> Cr-Commit-Position: refs/heads/master@{#17142}
> Committed:
https://chromium.googlesource.com/external/webrtc/+/94f4d9effc3fa1ee6a6a48a7b...

TBR=oprypin@webrtc.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=webrtc:7312
==========

[oprypin_webrtc, 2017-03-10 08:04:59]

lgtm

[kjellander_webrtc, 2017-04-05 13:01:28]

Finally got to test this properly in Chrome using:
out/Release/browser_tests
--gtest_filter=WebRtcVideoQualityBrowserTests/WebRtcVideoQualityBrowserTest.MANUAL_TestVideoQualityVp8/0
--run-manual --ui-test-action-max-timeout=350000 --test-launcher-jobs=1
--test-launcher-bot-mode --test-launcher-print-test-stdio=always

[kjellander_webrtc, 2017-04-05 13:39:49]

Description was changed from

==========
Reland of PyLint fixes for tools-webrtc and webrtc/tools (patchset #1 id:1 of
https://codereview.webrtc.org/2737233003/ )

Reason for revert:
Fixing errors for reland

Original issue's description:
> Revert of PyLint fixes for tools-webrtc and webrtc/tools (patchset #3 id:40001
of https://codereview.webrtc.org/2736233003/ )
> 
> Reason for revert:
> Fails video quality tests in Chrome: 
http://build.chromium.org/p/chromium.webrtc.fyi/builders/Win10%20Tester/build...
> I should have looked more closer at those :(
> 
> Original issue's description:
> > PyLint fixes for tools-webrtc and webrtc/tools
> > 
> > Fix a lot of errors before bringing in the new config in
> > https://codereview.webrtc.org/2737963003/
> > 
> > BUG=webrtc:7303
> > NOTRY=True
> > 
> > Review-Url: https://codereview.webrtc.org/2736233003
> > Cr-Commit-Position: refs/heads/master@{#17137}
> > Committed:
https://chromium.googlesource.com/external/webrtc/+/f5318e1f391859c82aaa47b29...
> 
> TBR=oprypin@webrtc.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=webrtc:7303
> 
> Review-Url: https://codereview.webrtc.org/2737233003
> Cr-Commit-Position: refs/heads/master@{#17142}
> Committed:
https://chromium.googlesource.com/external/webrtc/+/94f4d9effc3fa1ee6a6a48a7b...

TBR=oprypin@webrtc.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=webrtc:7312
==========

to

==========
Reland of PyLint fixes for tools-webrtc and webrtc/tools (patchset #1 id:1 of
https://codereview.webrtc.org/2737233003/ )

Reason for revert:
Fixing errors for reland

Original issue's description:
> Revert of PyLint fixes for tools-webrtc and webrtc/tools (patchset #3 id:40001
of https://codereview.webrtc.org/2736233003/ )
> 
> Reason for revert:
> Fails video quality tests in Chrome: 
http://build.chromium.org/p/chromium.webrtc.fyi/builders/Win10%20Tester/build...
> I should have looked more closer at those :(
> 
> Original issue's description:
> > PyLint fixes for tools-webrtc and webrtc/tools
> > 
> > Fix a lot of errors before bringing in the new config in
> > https://codereview.webrtc.org/2737963003/
> > 
> > BUG=webrtc:7303
> > NOTRY=True
> > 
> > Review-Url: https://codereview.webrtc.org/2736233003
> > Cr-Commit-Position: refs/heads/master@{#17137}
> > Committed:
https://chromium.googlesource.com/external/webrtc/+/f5318e1f391859c82aaa47b29...
> 
> TBR=oprypin@webrtc.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=webrtc:7303
> 
> Review-Url: https://codereview.webrtc.org/2737233003
> Cr-Commit-Position: refs/heads/master@{#17142}
> Committed:
https://chromium.googlesource.com/external/webrtc/+/94f4d9effc3fa1ee6a6a48a7b...

NOTRY=true
BUG=webrtc:7312
==========

[kjellander_webrtc, 2017-04-05 13:40:12]

Description was changed from

==========
Reland of PyLint fixes for tools-webrtc and webrtc/tools (patchset #1 id:1 of
https://codereview.webrtc.org/2737233003/ )

Reason for revert:
Fixing errors for reland

Original issue's description:
> Revert of PyLint fixes for tools-webrtc and webrtc/tools (patchset #3 id:40001
of https://codereview.webrtc.org/2736233003/ )
> 
> Reason for revert:
> Fails video quality tests in Chrome: 
http://build.chromium.org/p/chromium.webrtc.fyi/builders/Win10%20Tester/build...
> I should have looked more closer at those :(
> 
> Original issue's description:
> > PyLint fixes for tools-webrtc and webrtc/tools
> > 
> > Fix a lot of errors before bringing in the new config in
> > https://codereview.webrtc.org/2737963003/
> > 
> > BUG=webrtc:7303
> > NOTRY=True
> > 
> > Review-Url: https://codereview.webrtc.org/2736233003
> > Cr-Commit-Position: refs/heads/master@{#17137}
> > Committed:
https://chromium.googlesource.com/external/webrtc/+/f5318e1f391859c82aaa47b29...
> 
> TBR=oprypin@webrtc.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=webrtc:7303
> 
> Review-Url: https://codereview.webrtc.org/2737233003
> Cr-Commit-Position: refs/heads/master@{#17142}
> Committed:
https://chromium.googlesource.com/external/webrtc/+/94f4d9effc3fa1ee6a6a48a7b...

NOTRY=true
BUG=webrtc:7312
==========

to

==========
Reland of PyLint fixes for tools-webrtc and webrtc/tools (patchset #1 id:1 of
https://codereview.webrtc.org/2737233003/ )

Reason for revert:
Fixing errors for reland. I have tested that this does not make Chromium video
quality tests fail.

Original issue's description:
> Revert of PyLint fixes for tools-webrtc and webrtc/tools (patchset #3 id:40001
of https://codereview.webrtc.org/2736233003/ )
> 
> Reason for revert:
> Fails video quality tests in Chrome: 
http://build.chromium.org/p/chromium.webrtc.fyi/builders/Win10%20Tester/build...
> I should have looked more closer at those :(
> 
> Original issue's description:
> > PyLint fixes for tools-webrtc and webrtc/tools
> > 
> > Fix a lot of errors before bringing in the new config in
> > https://codereview.webrtc.org/2737963003/
> > 
> > BUG=webrtc:7303
> > NOTRY=True
> > 
> > Review-Url: https://codereview.webrtc.org/2736233003
> > Cr-Commit-Position: refs/heads/master@{#17137}
> > Committed:
https://chromium.googlesource.com/external/webrtc/+/f5318e1f391859c82aaa47b29...
> 
> TBR=oprypin@webrtc.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=webrtc:7303
> 
> Review-Url: https://codereview.webrtc.org/2737233003
> Cr-Commit-Position: refs/heads/master@{#17142}
> Committed:
https://chromium.googlesource.com/external/webrtc/+/94f4d9effc3fa1ee6a6a48a7b...

NOTRY=true
BUG=webrtc:7312
==========

[kjellander_webrtc, 2017-04-05 13:40:19]

The CQ bit was checked by kjellander@webrtc.org

[kjellander_webrtc, 2017-04-05 13:40:19]

The patchset sent to the CQ was uploaded after l-g-t-m from oprypin@webrtc.org
Link to the patchset: https://codereview.webrtc.org/2741733003/#ps270001 (title:
"Rebased")

[commit-bot: I haz the power, 2017-04-05 13:40:26]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-04-05 13:42:43]

CQ is committing da patch.

Bot data: {"patchset_id": 270001, "attempt_start_ts": 1491399619081950,
"parent_rev": "adf0635ed54f5c7b87c8d2ee774f2a5bbf6f1828", "commit_rev":
"c88b5d56ada5690ae352062e69a9f984a07d228c"}

[commit-bot: I haz the power, 2017-04-05 13:42:47]

Description was changed from

==========
Reland of PyLint fixes for tools-webrtc and webrtc/tools (patchset #1 id:1 of
https://codereview.webrtc.org/2737233003/ )

Reason for revert:
Fixing errors for reland. I have tested that this does not make Chromium video
quality tests fail.

Original issue's description:
> Revert of PyLint fixes for tools-webrtc and webrtc/tools (patchset #3 id:40001
of https://codereview.webrtc.org/2736233003/ )
> 
> Reason for revert:
> Fails video quality tests in Chrome: 
http://build.chromium.org/p/chromium.webrtc.fyi/builders/Win10%20Tester/build...
> I should have looked more closer at those :(
> 
> Original issue's description:
> > PyLint fixes for tools-webrtc and webrtc/tools
> > 
> > Fix a lot of errors before bringing in the new config in
> > https://codereview.webrtc.org/2737963003/
> > 
> > BUG=webrtc:7303
> > NOTRY=True
> > 
> > Review-Url: https://codereview.webrtc.org/2736233003
> > Cr-Commit-Position: refs/heads/master@{#17137}
> > Committed:
https://chromium.googlesource.com/external/webrtc/+/f5318e1f391859c82aaa47b29...
> 
> TBR=oprypin@webrtc.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=webrtc:7303
> 
> Review-Url: https://codereview.webrtc.org/2737233003
> Cr-Commit-Position: refs/heads/master@{#17142}
> Committed:
https://chromium.googlesource.com/external/webrtc/+/94f4d9effc3fa1ee6a6a48a7b...

NOTRY=true
BUG=webrtc:7312
==========

to

==========
Reland of PyLint fixes for tools-webrtc and webrtc/tools (patchset #1 id:1 of
https://codereview.webrtc.org/2737233003/ )

Reason for revert:
Fixing errors for reland. I have tested that this does not make Chromium video
quality tests fail.

Original issue's description:
> Revert of PyLint fixes for tools-webrtc and webrtc/tools (patchset #3 id:40001
of https://codereview.webrtc.org/2736233003/ )
> 
> Reason for revert:
> Fails video quality tests in Chrome: 
http://build.chromium.org/p/chromium.webrtc.fyi/builders/Win10%20Tester/build...
> I should have looked more closer at those :(
> 
> Original issue's description:
> > PyLint fixes for tools-webrtc and webrtc/tools
> > 
> > Fix a lot of errors before bringing in the new config in
> > https://codereview.webrtc.org/2737963003/
> > 
> > BUG=webrtc:7303
> > NOTRY=True
> > 
> > Review-Url: https://codereview.webrtc.org/2736233003
> > Cr-Commit-Position: refs/heads/master@{#17137}
> > Committed:
https://chromium.googlesource.com/external/webrtc/+/f5318e1f391859c82aaa47b29...
> 
> TBR=oprypin@webrtc.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=webrtc:7303
> 
> Review-Url: https://codereview.webrtc.org/2737233003
> Cr-Commit-Position: refs/heads/master@{#17142}
> Committed:
https://chromium.googlesource.com/external/webrtc/+/94f4d9effc3fa1ee6a6a48a7b...

NOTRY=true
BUG=webrtc:7312

Review-Url: https://codereview.webrtc.org/2741733003
Cr-Commit-Position: refs/heads/master@{#17541}
Committed:
https://chromium.googlesource.com/external/webrtc/+/c88b5d56ada5690ae352062e6...
==========

[commit-bot: I haz the power, 2017-04-05 13:42:48]

Committed patchset #3 (id:270001) as
https://chromium.googlesource.com/external/webrtc/+/c88b5d56ada5690ae352062e6...