Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(117)

Issue 2737233003: Revert of PyLint fixes for tools-webrtc and webrtc/tools (Closed)

Created:
3 years, 9 months ago by kjellander_webrtc
Modified:
3 years, 9 months ago
Reviewers:
oprypin_webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, qiang.lu, niklas.enbom, yujie_mao (webrtc), peah-webrtc
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of PyLint fixes for tools-webrtc and webrtc/tools (patchset #3 id:40001 of https://codereview.webrtc.org/2736233003/ ) Reason for revert: Fails video quality tests in Chrome: http://build.chromium.org/p/chromium.webrtc.fyi/builders/Win10%20Tester/builds/6568 I should have looked more closer at those :( Original issue's description: > PyLint fixes for tools-webrtc and webrtc/tools > > Fix a lot of errors before bringing in the new config in > https://codereview.webrtc.org/2737963003/ > > BUG=webrtc:7303 > NOTRY=True > > Review-Url: https://codereview.webrtc.org/2736233003 > Cr-Commit-Position: refs/heads/master@{#17137} > Committed: https://chromium.googlesource.com/external/webrtc/+/f5318e1f391859c82aaa47b297429e50f41f6b3c TBR=oprypin@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:7303 Review-Url: https://codereview.webrtc.org/2737233003 Cr-Commit-Position: refs/heads/master@{#17142} Committed: https://chromium.googlesource.com/external/webrtc/+/94f4d9effc3fa1ee6a6a48a7bbdef6684defd1dc

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+145 lines, -142 lines) Patch
M PRESUBMIT.py View 4 chunks +6 lines, -6 lines 0 comments Download
M cleanup_links.py View 2 chunks +2 lines, -2 lines 0 comments Download
M tools-webrtc/autoroller/unittests/roll_deps_test.py View 4 chunks +7 lines, -7 lines 0 comments Download
M tools-webrtc/check_package_boundaries.py View 2 chunks +2 lines, -2 lines 0 comments Download
M tools-webrtc/check_package_boundaries_test.py View 2 chunks +6 lines, -6 lines 0 comments Download
M tools-webrtc/get_landmines.py View 2 chunks +9 lines, -6 lines 0 comments Download
M tools-webrtc/gn_check_autofix.py View 1 chunk +1 line, -1 line 0 comments Download
M tools-webrtc/network_emulator/emulate.py View 6 chunks +11 lines, -11 lines 0 comments Download
M tools-webrtc/network_emulator/network_emulator.py View 5 chunks +19 lines, -19 lines 0 comments Download
M webrtc/examples/androidtests/video_quality_loopback_test.py View 2 chunks +3 lines, -3 lines 0 comments Download
M webrtc/tools/barcode_tools/barcode_decoder.py View 12 chunks +23 lines, -23 lines 0 comments Download
M webrtc/tools/barcode_tools/barcode_encoder.py View 15 chunks +37 lines, -37 lines 0 comments Download
M webrtc/tools/barcode_tools/build_zxing.py View 2 chunks +5 lines, -5 lines 0 comments Download
M webrtc/tools/barcode_tools/helper_functions.py View 4 chunks +5 lines, -5 lines 0 comments Download
M webrtc/tools/barcode_tools/yuv_cropper.py View 5 chunks +9 lines, -9 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
kjellander_webrtc
Created Revert of PyLint fixes for tools-webrtc and webrtc/tools
3 years, 9 months ago (2017-03-09 14:09:22 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2737233003/1
3 years, 9 months ago (2017-03-09 14:09:28 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/external/webrtc/+/94f4d9effc3fa1ee6a6a48a7bbdef6684defd1dc
3 years, 9 months ago (2017-03-09 14:09:38 UTC) #6
kjellander_webrtc
3 years, 9 months ago (2017-03-09 14:34:16 UTC) #7
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.webrtc.org/2741733003/ by kjellander@webrtc.org.

The reason for reverting is: Fixing errors for reland.

Powered by Google App Engine
This is Rietveld 408576698