PyLint fixes for tools-webrtc and webrtc/tools

PyLint fixes for tools-webrtc and webrtc/tools

Fix a lot of errors before bringing in the new config in
https://codereview.webrtc.org/2737963003/

BUG=webrtc:7303
NOTRY=True

Review-Url: https://codereview.webrtc.org/2736233003
Cr-Commit-Position: refs/heads/master@{#17137}
Committed: https://chromium.googlesource.com/external/webrtc/+/f5318e1f391859c82aaa47b297429e50f41f6b3c

[kjellander_webrtc, 2017-03-09 06:25:22]

kjellander@webrtc.org changed reviewers:
+ oprypin@webrtc.org

[kjellander_webrtc, 2017-03-09 06:25:22]

Sorry, not the most exciting review :/

[kjellander_webrtc, 2017-03-09 07:26:59]

Description was changed from

==========
PyLint fixes to align with new pylintrc.

Fix a lot of errors before bringing in the new config in
https://codereview.webrtc.org/2737963003/

BUG=webrtc:7303
NOTRY=True
==========

to

==========
PyLint fixes for tools-webrtc and webrtc/tools

Fix a lot of errors before bringing in the new config in
https://codereview.webrtc.org/2737963003/

BUG=webrtc:7303
NOTRY=True
==========

[oprypin_webrtc, 2017-03-09 08:41:49]

All my comments are about alignment. I wonder why the linter doesn't do anything
about this.

https://codereview.webrtc.org/2736233003/diff/20001/tools-webrtc/network_emul...
File tools-webrtc/network_emulator/network_emulator.py (right):

https://codereview.webrtc.org/2736233003/diff/20001/tools-webrtc/network_emul...
tools-webrtc/network_emulator/network_emulator.py:81: 'any', self._port_range)
Misaligned here and above.

https://codereview.webrtc.org/2736233003/diff/20001/webrtc/tools/barcode_tool...
File webrtc/tools/barcode_tools/barcode_decoder.py (right):

https://codereview.webrtc.org/2736233003/diff/20001/webrtc/tools/barcode_tool...
webrtc/tools/barcode_tools/barcode_decoder.py:274:
ffmpeg_path=options.ffmpeg_path):
Misaligned

https://codereview.webrtc.org/2736233003/diff/20001/webrtc/tools/barcode_tool...
webrtc/tools/barcode_tools/barcode_decoder.py:286:
input_directory=options.png_working_dir)
Misaligned here and above

https://codereview.webrtc.org/2736233003/diff/20001/webrtc/tools/barcode_tool...
File webrtc/tools/barcode_tools/barcode_encoder.py (right):

https://codereview.webrtc.org/2736233003/diff/20001/webrtc/tools/barcode_tool...
webrtc/tools/barcode_tools/barcode_encoder.py:22:
path_to_zxing='zxing-read-only'):
Misaligned

https://codereview.webrtc.org/2736233003/diff/20001/webrtc/tools/barcode_tool...
webrtc/tools/barcode_tools/barcode_encoder.py:236: base_component_sizes)
Misaligned

https://codereview.webrtc.org/2736233003/diff/20001/webrtc/tools/barcode_tool...
webrtc/tools/barcode_tools/barcode_encoder.py:364: options.barcodes_yuv,
options.base_yuv, options.output_yuv)
Misaligned here and above

[kjellander_webrtc, 2017-03-09 08:58:14]

The linter doesn't catch those because the "bad-continuation" rule is disabled
in pylintrc. It would spit out a large number of errors so that needs to be done
separately.

My focus was on getting us able to detect the invalid naming of methods and
functions that we have in many places, and prevent it from spreading further.

https://codereview.webrtc.org/2736233003/diff/20001/tools-webrtc/network_emul...
File tools-webrtc/network_emulator/network_emulator.py (right):

https://codereview.webrtc.org/2736233003/diff/20001/tools-webrtc/network_emul...
tools-webrtc/network_emulator/network_emulator.py:81: 'any', self._port_range)
On 2017/03/09 08:41:49, oprypin_webrtc wrote:
> Misaligned here and above.

Done.

https://codereview.webrtc.org/2736233003/diff/20001/webrtc/tools/barcode_tool...
File webrtc/tools/barcode_tools/barcode_decoder.py (right):

https://codereview.webrtc.org/2736233003/diff/20001/webrtc/tools/barcode_tool...
webrtc/tools/barcode_tools/barcode_decoder.py:274:
ffmpeg_path=options.ffmpeg_path):
On 2017/03/09 08:41:49, oprypin_webrtc wrote:
> Misaligned

Done.

https://codereview.webrtc.org/2736233003/diff/20001/webrtc/tools/barcode_tool...
webrtc/tools/barcode_tools/barcode_decoder.py:286:
input_directory=options.png_working_dir)
On 2017/03/09 08:41:49, oprypin_webrtc wrote:
> Misaligned here and above

Done.

https://codereview.webrtc.org/2736233003/diff/20001/webrtc/tools/barcode_tool...
File webrtc/tools/barcode_tools/barcode_encoder.py (right):

https://codereview.webrtc.org/2736233003/diff/20001/webrtc/tools/barcode_tool...
webrtc/tools/barcode_tools/barcode_encoder.py:22:
path_to_zxing='zxing-read-only'):
On 2017/03/09 08:41:49, oprypin_webrtc wrote:
> Misaligned

Done.

https://codereview.webrtc.org/2736233003/diff/20001/webrtc/tools/barcode_tool...
webrtc/tools/barcode_tools/barcode_encoder.py:236: base_component_sizes)
On 2017/03/09 08:41:49, oprypin_webrtc wrote:
> Misaligned

Done.

https://codereview.webrtc.org/2736233003/diff/20001/webrtc/tools/barcode_tool...
webrtc/tools/barcode_tools/barcode_encoder.py:364: options.barcodes_yuv,
options.base_yuv, options.output_yuv)
On 2017/03/09 08:41:49, oprypin_webrtc wrote:
> Misaligned here and above

Done.

[oprypin_webrtc, 2017-03-09 09:04:10]

lgtm

[kjellander_webrtc, 2017-03-09 09:18:26]

The CQ bit was checked by kjellander@webrtc.org

[commit-bot: I haz the power, 2017-03-09 09:18:33]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-03-09 09:22:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-09 09:22:43]

Try jobs failed on following builders:
  presubmit on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/14642)

[kjellander_webrtc, 2017-03-09 10:23:28]

The CQ bit was checked by kjellander@webrtc.org

[commit-bot: I haz the power, 2017-03-09 10:23:33]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[kjellander_webrtc, 2017-03-09 10:23:37]

The CQ bit was unchecked by kjellander@webrtc.org

[kjellander_webrtc, 2017-03-09 10:23:38]

The CQ bit was checked by kjellander@webrtc.org

[kjellander_webrtc, 2017-03-09 10:23:40]

The CQ bit was unchecked by kjellander@webrtc.org

[kjellander_webrtc, 2017-03-09 10:24:17]

The CQ bit was checked by kjellander@webrtc.org

[commit-bot: I haz the power, 2017-03-09 10:24:23]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-03-09 10:26:47]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1489055057141390,
"parent_rev": "735da3ad38b9387f3a2b4ef778a0c8c40a1e75ff", "commit_rev":
"f5318e1f391859c82aaa47b297429e50f41f6b3c"}

[commit-bot: I haz the power, 2017-03-09 10:26:49]

Description was changed from

==========
PyLint fixes for tools-webrtc and webrtc/tools

Fix a lot of errors before bringing in the new config in
https://codereview.webrtc.org/2737963003/

BUG=webrtc:7303
NOTRY=True
==========

to

==========
PyLint fixes for tools-webrtc and webrtc/tools

Fix a lot of errors before bringing in the new config in
https://codereview.webrtc.org/2737963003/

BUG=webrtc:7303
NOTRY=True

Review-Url: https://codereview.webrtc.org/2736233003
Cr-Commit-Position: refs/heads/master@{#17137}
Committed:
https://chromium.googlesource.com/external/webrtc/+/f5318e1f391859c82aaa47b29...
==========

[commit-bot: I haz the power, 2017-03-09 10:26:50]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/external/webrtc/+/f5318e1f391859c82aaa47b29...

[kjellander_webrtc, 2017-03-09 14:09:22]

A revert of this CL (patchset #3 id:40001) has been created in
https://codereview.webrtc.org/2737233003/ by kjellander@webrtc.org.

The reason for reverting is: Fails video quality tests in Chrome: 
http://build.chromium.org/p/chromium.webrtc.fyi/builders/Win10%20Tester/build...
I should have looked more closer at those :(.