Index: PRESUBMIT.py |
diff --git a/PRESUBMIT.py b/PRESUBMIT.py |
index f7500e80768f8c0750263afa5156f9e8cf6f48ec..df4f55fe6b9188ef42558c0cf92747a75d7f7da1 100755 |
--- a/PRESUBMIT.py |
+++ b/PRESUBMIT.py |
@@ -115,7 +115,7 @@ def _VerifyNativeApiHeadersListIsValid(input_api, output_api): |
non_existing_paths)] |
return [] |
-api_change_msg = """ |
+API_CHANGE_MSG = """ |
You seem to be changing native API header files. Please make sure that you: |
1. Make compatible changes that don't break existing clients. Usually |
this is done by keeping the existing method signatures unchanged. |
@@ -144,7 +144,7 @@ def _CheckNativeApiHeaderChanges(input_api, output_api): |
files.append(f) |
if files: |
- return [output_api.PresubmitNotifyResult(api_change_msg, files)] |
+ return [output_api.PresubmitNotifyResult(API_CHANGE_MSG, files)] |
return [] |
@@ -189,7 +189,7 @@ def _CheckNoPragmaOnce(input_api, output_api): |
return [] |
-def _CheckNoFRIEND_TEST(input_api, output_api): |
+def _CheckNoFRIEND_TEST(input_api, output_api): # pylint: disable=invalid-name |
"""Make sure that gtest's FRIEND_TEST() macro is not used, the |
FRIEND_TEST_ALL_PREFIXES() macro from testsupport/gtest_prod_util.h should be |
used instead since that allows for FLAKY_, FAILS_ and DISABLED_ prefixes.""" |
@@ -451,13 +451,13 @@ def _CheckJSONParseErrors(input_api, output_api): |
def _RunPythonTests(input_api, output_api): |
- def join(*args): |
+ def Join(*args): |
return input_api.os_path.join(input_api.PresubmitLocalPath(), *args) |
test_directories = [ |
- join('webrtc', 'tools', 'py_event_log_analyzer') |
+ Join('webrtc', 'tools', 'py_event_log_analyzer') |
] + [ |
- root for root, _, files in os.walk(join('tools-webrtc')) |
+ root for root, _, files in os.walk(Join('tools-webrtc')) |
if any(f.endswith('_test.py') for f in files) |
] |