Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(452)

Unified Diff: PRESUBMIT.py

Issue 2737233003: Revert of PyLint fixes for tools-webrtc and webrtc/tools (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | cleanup_links.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: PRESUBMIT.py
diff --git a/PRESUBMIT.py b/PRESUBMIT.py
index df4f55fe6b9188ef42558c0cf92747a75d7f7da1..f7500e80768f8c0750263afa5156f9e8cf6f48ec 100755
--- a/PRESUBMIT.py
+++ b/PRESUBMIT.py
@@ -115,7 +115,7 @@
non_existing_paths)]
return []
-API_CHANGE_MSG = """
+api_change_msg = """
You seem to be changing native API header files. Please make sure that you:
1. Make compatible changes that don't break existing clients. Usually
this is done by keeping the existing method signatures unchanged.
@@ -144,7 +144,7 @@
files.append(f)
if files:
- return [output_api.PresubmitNotifyResult(API_CHANGE_MSG, files)]
+ return [output_api.PresubmitNotifyResult(api_change_msg, files)]
return []
@@ -189,7 +189,7 @@
return []
-def _CheckNoFRIEND_TEST(input_api, output_api): # pylint: disable=invalid-name
+def _CheckNoFRIEND_TEST(input_api, output_api):
"""Make sure that gtest's FRIEND_TEST() macro is not used, the
FRIEND_TEST_ALL_PREFIXES() macro from testsupport/gtest_prod_util.h should be
used instead since that allows for FLAKY_, FAILS_ and DISABLED_ prefixes."""
@@ -451,13 +451,13 @@
def _RunPythonTests(input_api, output_api):
- def Join(*args):
+ def join(*args):
return input_api.os_path.join(input_api.PresubmitLocalPath(), *args)
test_directories = [
- Join('webrtc', 'tools', 'py_event_log_analyzer')
+ join('webrtc', 'tools', 'py_event_log_analyzer')
] + [
- root for root, _, files in os.walk(Join('tools-webrtc'))
+ root for root, _, files in os.walk(join('tools-webrtc'))
if any(f.endswith('_test.py') for f in files)
]
« no previous file with comments | « no previous file | cleanup_links.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698