Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(323)

Unified Diff: tools-webrtc/check_package_boundaries_test.py

Issue 2737233003: Revert of PyLint fixes for tools-webrtc and webrtc/tools (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools-webrtc/check_package_boundaries.py ('k') | tools-webrtc/get_landmines.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools-webrtc/check_package_boundaries_test.py
diff --git a/tools-webrtc/check_package_boundaries_test.py b/tools-webrtc/check_package_boundaries_test.py
index 1487a230e8d7a2aff1aed9911d7f06a3105e3891..c59c4850b3dbf3616e8f4a3cad0bebcb7f3e3fde 100755
--- a/tools-webrtc/check_package_boundaries_test.py
+++ b/tools-webrtc/check_package_boundaries_test.py
@@ -30,7 +30,7 @@
self.messages = []
self.test_dir = test_dir
- def Log(self, build_file_path, line_number, target_name, source_file,
+ def log(self, build_file_path, line_number, target_name, source_file,
subpackage):
build_file_path = os.path.relpath(build_file_path, self.test_dir)
build_file_path = build_file_path.replace(os.path.sep, '/')
@@ -48,19 +48,19 @@
expected_messages = ReadPylFile(os.path.join(test_dir, 'expected.pyl'))
self.assertListEqual(sorted(expected_messages), sorted(logger.messages))
- def testNoErrors(self):
+ def test_no_errors(self):
self.RunTest(os.path.join(TESTDATA_DIR, 'no_errors'))
- def testMultipleErrorsSingleTarget(self):
+ def test_multiple_errors_single_target(self):
self.RunTest(os.path.join(TESTDATA_DIR, 'multiple_errors_single_target'))
- def testMultipleErrorsMultipleTargets(self):
+ def test_multiple_errors_multiple_targets(self):
self.RunTest(os.path.join(TESTDATA_DIR, 'multiple_errors_multiple_targets'))
- def testCommonPrefix(self):
+ def test_common_prefix(self):
self.RunTest(os.path.join(TESTDATA_DIR, 'common_prefix'))
- def testAllBuildFiles(self):
+ def test_all_build_files(self):
self.RunTest(os.path.join(TESTDATA_DIR, 'all_build_files'), True)
« no previous file with comments | « tools-webrtc/check_package_boundaries.py ('k') | tools-webrtc/get_landmines.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698