Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(412)

Side by Side Diff: tools-webrtc/get_landmines.py

Issue 2741733003: Reland of PyLint fixes for tools-webrtc and webrtc/tools (Closed)
Patch Set: Rebased Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « tools-webrtc/check_package_boundaries_test.py ('k') | tools-webrtc/gn_check_autofix.py » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 #!/usr/bin/env python 1 #!/usr/bin/env python
2 # Copyright (c) 2015 The WebRTC project authors. All Rights Reserved. 2 # Copyright (c) 2015 The WebRTC project authors. All Rights Reserved.
3 # 3 #
4 # Use of this source code is governed by a BSD-style license 4 # Use of this source code is governed by a BSD-style license
5 # that can be found in the LICENSE file in the root of the source 5 # that can be found in the LICENSE file in the root of the source
6 # tree. An additional intellectual property rights grant can be found 6 # tree. An additional intellectual property rights grant can be found
7 # in the file PATENTS. All contributing project authors may 7 # in the file PATENTS. All contributing project authors may
8 # be found in the AUTHORS file in the root of the source tree. 8 # be found in the AUTHORS file in the root of the source tree.
9 9
10 """ 10 """
11 This file emits the list of reasons why a particular build needs to be clobbered 11 This file emits the list of reasons why a particular build needs to be clobbered
12 (or a list of 'landmines'). 12 (or a list of 'landmines').
13 """ 13 """
14 14
15 import os 15 import os
16 import sys 16 import sys
17 17
18 script_dir = os.path.dirname(os.path.realpath(__file__)) 18 SCRIPT_DIR = os.path.dirname(os.path.realpath(__file__))
19 checkout_root = os.path.abspath(os.path.join(script_dir, os.pardir)) 19 CHECKOUT_ROOT = os.path.abspath(os.path.join(SCRIPT_DIR, os.pardir))
20 sys.path.insert(0, os.path.join(checkout_root, 'build')) 20 sys.path.insert(0, os.path.join(CHECKOUT_ROOT, 'build'))
21 import landmine_utils 21 import landmine_utils
22 22
23 23
24 distributor = landmine_utils.distributor 24 platform = landmine_utils.platform # pylint: disable=invalid-name
25 gyp_defines = landmine_utils.gyp_defines
26 gyp_msvs_version = landmine_utils.gyp_msvs_version
27 platform = landmine_utils.platform
28 25
29 26
30 def print_landmines(): 27 def print_landmines(): # pylint: disable=invalid-name
31 """ 28 """
32 ALL LANDMINES ARE EMITTED FROM HERE. 29 ALL LANDMINES ARE EMITTED FROM HERE.
33 """ 30 """
34 # DO NOT add landmines as part of a regular CL. Landmines are a last-effort 31 # DO NOT add landmines as part of a regular CL. Landmines are a last-effort
35 # bandaid fix if a CL that got landed has a build dependency bug and all bots 32 # bandaid fix if a CL that got landed has a build dependency bug and all bots
36 # need to be cleaned up. If you're writing a new CL that causes build 33 # need to be cleaned up. If you're writing a new CL that causes build
37 # dependency problems, fix the dependency problems instead of adding a 34 # dependency problems, fix the dependency problems instead of adding a
38 # landmine. 35 # landmine.
39 # See the Chromium version in src/build/get_landmines.py for usage examples. 36 # See the Chromium version in src/build/get_landmines.py for usage examples.
40 print 'Clobber to remove out/{Debug,Release}/args.gn (webrtc:5070)' 37 print 'Clobber to remove out/{Debug,Release}/args.gn (webrtc:5070)'
(...skipping 23 matching lines...) Expand all
64 print 'Another landmine for low_bandwidth_audio_test (webrtc:7430)' 61 print 'Another landmine for low_bandwidth_audio_test (webrtc:7430)'
65 62
66 63
67 def main(): 64 def main():
68 print_landmines() 65 print_landmines()
69 return 0 66 return 0
70 67
71 68
72 if __name__ == '__main__': 69 if __name__ == '__main__':
73 sys.exit(main()) 70 sys.exit(main())
OLDNEW
« no previous file with comments | « tools-webrtc/check_package_boundaries_test.py ('k') | tools-webrtc/gn_check_autofix.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698