Reland of PyLint fixes for tools-webrtc and webrtc/tools

PRESUBMIT.py

 # Copyright (c) 2012 The WebRTC project authors. All Rights Reserved.
 #
 # Use of this source code is governed by a BSD-style license
 # that can be found in the LICENSE file in the root of the source
 # tree. An additional intellectual property rights grant can be found
 # in the file PATENTS.  All contributing project authors may
 # be found in the AUTHORS file in the root of the source tree.
 
 import json
 import os
@@ skipping 108 matching lines @@
     if not os.path.isdir(path):
       non_existing_paths.append(path)
   if non_existing_paths:
     return [output_api.PresubmitError(
         'Directories to native API headers have changed which has made the '
         'list in PRESUBMIT.py outdated.\nPlease update it to the current '
         'location of our native APIs.',
         non_existing_paths)]
   return []
 
-api_change_msg = """
+API_CHANGE_MSG = """
 You seem to be changing native API header files. Please make sure that you:
   1. Make compatible changes that don't break existing clients. Usually
      this is done by keeping the existing method signatures unchanged.
   2. Mark the old stuff as deprecated (see RTC_DEPRECATED macro).
   3. Create a timeline and plan for when the deprecated stuff will be
      removed. (The amount of time we give users to change their code
      should be informed by how much work it is for them. If they just
      need to replace one name with another or something equally
      simple, 1-2 weeks might be good; if they need to do serious work,
      up to 3 months may be called for.)
   4. Update/inform existing downstream code owners to stop using the
      deprecated stuff. (Send announcements to
      discuss-webrtc@googlegroups.com and webrtc-users@google.com.)
   5. Remove the deprecated stuff, once the agreed-upon amount of time
      has passed.
 Related files:
 """
 
 def _CheckNativeApiHeaderChanges(input_api, output_api):
   """Checks to remind proper changing of native APIs."""
   files = []
   for f in input_api.AffectedSourceFiles(input_api.FilterSourceFile):
     if f.LocalPath().endswith('.h'):
       for path in API_DIRS:
         if os.path.dirname(f.LocalPath()) == path:
           files.append(f)
 
   if files:
-    return [output_api.PresubmitNotifyResult(api_change_msg, files)]
+    return [output_api.PresubmitNotifyResult(API_CHANGE_MSG, files)]
   return []
 
 
 def _CheckNoIOStreamInHeaders(input_api, output_api):
   """Checks to make sure no .h files include <iostream>."""
   files = []
   pattern = input_api.re.compile(r'^#include\s*<iostream>',
                                  input_api.re.MULTILINE)
   for f in input_api.AffectedSourceFiles(input_api.FilterSourceFile):
     if not f.LocalPath().endswith('.h'):
@@ skipping 24 matching lines @@
       files.append(f)
 
   if files:
     return [output_api.PresubmitError(
         'Do not use #pragma once in header files.\n'
         'See http://www.chromium.org/developers/coding-style#TOC-File-headers',
         files)]
   return []
 
 
-def _CheckNoFRIEND_TEST(input_api, output_api):
+def _CheckNoFRIEND_TEST(input_api, output_api):  # pylint: disable=invalid-name
   """Make sure that gtest's FRIEND_TEST() macro is not used, the
   FRIEND_TEST_ALL_PREFIXES() macro from testsupport/gtest_prod_util.h should be
   used instead since that allows for FLAKY_, FAILS_ and DISABLED_ prefixes."""
   problems = []
 
   file_filter = lambda f: f.LocalPath().endswith(('.cc', '.h'))
   for f in input_api.AffectedFiles(file_filter=file_filter):
     for line_num, line in f.ChangedContents():
       if 'FRIEND_TEST(' in line:
         problems.append('    %s:%d' % (f.LocalPath(), line_num))
@@ skipping 245 matching lines @@
       file_filter=FilterFile, include_deletes=False):
     parse_error = GetJSONParseError(input_api,
                                     affected_file.AbsoluteLocalPath())
     if parse_error:
       results.append(output_api.PresubmitError('%s could not be parsed: %s' %
           (affected_file.LocalPath(), parse_error)))
   return results
 
 
 def _RunPythonTests(input_api, output_api):
-  def join(*args):
+  def Join(*args):
     return input_api.os_path.join(input_api.PresubmitLocalPath(), *args)
 
   test_directories = [
-      join('webrtc', 'tools', 'py_event_log_analyzer')
+      Join('webrtc', 'tools', 'py_event_log_analyzer')
   ] + [
-      root for root, _, files in os.walk(join('tools-webrtc'))
+      root for root, _, files in os.walk(Join('tools-webrtc'))
       if any(f.endswith('_test.py') for f in files)
   ]
 
   tests = []
   for directory in test_directories:
     tests.extend(
       input_api.canned_checks.GetUnitTestsInDirectory(
           input_api,
           output_api,
           directory,
@@ skipping 89 matching lines @@
       input_api, output_api))
   results.extend(input_api.canned_checks.CheckChangeHasDescription(
       input_api, output_api))
   results.extend(_CheckChangeHasBugField(input_api, output_api))
   results.extend(input_api.canned_checks.CheckChangeHasTestField(
       input_api, output_api))
   results.extend(input_api.canned_checks.CheckTreeIsOpen(
       input_api, output_api,
       json_url='http://webrtc-status.appspot.com/current?format=json'))
   return results