Reland of PyLint fixes for tools-webrtc and webrtc/tools

tools-webrtc/network_emulator/emulate.py

 #!/usr/bin/env python
 #  Copyright (c) 2012 The WebRTC project authors. All Rights Reserved.
 #
 #  Use of this source code is governed by a BSD-style license
 #  that can be found in the LICENSE file in the root of the source
 #  tree. An additional intellectual property rights grant can be found
 #  in the file PATENTS.  All contributing project authors may
 #  be found in the AUTHORS file in the root of the source tree.
 
 """Script for constraining traffic on the local machine."""
@@ skipping 37 matching lines @@
 _DEFAULT_PRESET = _PRESETS_DICT[_DEFAULT_PRESET_ID]
 
 
 class NonStrippingEpilogOptionParser(optparse.OptionParser):
   """Custom parser to let us show the epilog without weird line breaking."""
 
   def format_epilog(self, formatter):
     return self.epilog
 
 
-def _get_external_ip():
+def _GetExternalIp():
   """Finds out the machine's external IP by connecting to google.com."""
   external_socket = socket.socket(socket.AF_INET, socket.SOCK_DGRAM)
   external_socket.connect(('google.com', 80))
   return external_socket.getsockname()[0]
 
 
-def _parse_args():
+def _ParseArgs():
   """Define and parse the command-line arguments."""
   presets_string = '\n'.join(str(p) for p in _PRESETS)
   parser = NonStrippingEpilogOptionParser(epilog=(
       '\nAvailable presets:\n'
       '                              Bandwidth (kbps)                  Packet\n'
       'ID Name                       Receive     Send    Queue  Delay   loss \n'
       '-- ----                      ---------   -------- ----- ------- ------\n'
       '%s\n' % presets_string))
   parser.add_option('-p', '--preset', type='int', default=_DEFAULT_PRESET_ID,
                     help=('ConnectionConfig configuration, specified by ID. '
@@ skipping 40 matching lines @@
   try:
     if isinstance(options.port_range, str):
       options.port_range = tuple(int(port) for port in
                                  options.port_range.split(','))
       if len(options.port_range) != 2:
         parser.error('Invalid port range specified, please specify two '
                      'integers separated by a comma.')
   except ValueError:
     parser.error('Invalid port range specified.')
 
-  _set_logger(options.verbose)
+  _InitLogging(options.verbose)
   return options
 
 
-def _set_logger(verbose):
+def _InitLogging(verbose):
   """Setup logging."""
   log_level = _DEFAULT_LOG_LEVEL
   if verbose:
     log_level = logging.DEBUG
   logging.basicConfig(level=log_level, format='%(message)s')
 
 
-def _main():
-  options = _parse_args()
+def main():
+  options = _ParseArgs()
 
   # Build a configuration object. Override any preset configuration settings if
   # a value of a setting was also given as a flag.
   connection_config = _PRESETS_DICT[options.preset]
   if options.receive_bw is not _DEFAULT_PRESET.receive_bw_kbps:
     connection_config.receive_bw_kbps = options.receive_bw
   if options.send_bw is not _DEFAULT_PRESET.send_bw_kbps:
     connection_config.send_bw_kbps = options.send_bw
   if options.delay is not _DEFAULT_PRESET.delay_ms:
     connection_config.delay_ms = options.delay
   if options.packet_loss is not _DEFAULT_PRESET.packet_loss_percent:
     connection_config.packet_loss_percent = options.packet_loss
   if options.queue is not _DEFAULT_PRESET.queue_slots:
     connection_config.queue_slots = options.queue
   emulator = network_emulator.NetworkEmulator(connection_config,
                                               options.port_range)
   try:
-    emulator.check_permissions()
+    emulator.CheckPermissions()
   except network_emulator.NetworkEmulatorError as e:
     logging.error('Error: %s\n\nCause: %s', e.fail_msg, e.error)
     return -1
 
   if not options.target_ip:
-    external_ip = _get_external_ip()
+    external_ip = _GetExternalIp()
   else:
     external_ip = options.target_ip
 
   logging.info('Constraining traffic to/from IP: %s', external_ip)
   try:
-    emulator.emulate(external_ip)
+    emulator.Emulate(external_ip)
     logging.info('Started network emulation with the following configuration:\n'
                  '  Receive bandwidth: %s kbps (%s kB/s)\n'
                  '  Send bandwidth   : %s kbps (%s kB/s)\n'
                  '  Delay            : %s ms\n'
                  '  Packet loss      : %s %%\n'
                  '  Queue slots      : %s',
                  connection_config.receive_bw_kbps,
                  connection_config.receive_bw_kbps/8,
                  connection_config.send_bw_kbps,
                  connection_config.send_bw_kbps/8,
                  connection_config.delay_ms,
                  connection_config.packet_loss_percent,
                  connection_config.queue_slots)
     logging.info('Affected traffic: IP traffic on ports %s-%s',
                  options.port_range[0], options.port_range[1])
     raw_input('Press Enter to abort Network Emulation...')
     logging.info('Flushing all Dummynet rules...')
-    network_emulator.cleanup()
+    network_emulator.Cleanup()
     logging.info('Completed Network Emulation.')
     return 0
   except network_emulator.NetworkEmulatorError as e:
     logging.error('Error: %s\n\nCause: %s', e.fail_msg, e.error)
     return -2
 
 if __name__ == '__main__':
-  sys.exit(_main())
+  sys.exit(main())