Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(492)

Issue 2712513002: DevTools: extract ObjectUI module from Components (Closed)

Created:
3 years, 10 months ago by chenwilliam
Modified:
3 years, 10 months ago
Reviewers:
dgozman, alph, pfeldman
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, caseq+blink_chromium.org, aboxhall, extensions-reviews_chromium.org, aboxhall+watch_chromium.org, nektar+watch_chromium.org, lushnikov+blink_chromium.org, yuzo+watch_chromium.org, pfeldman+blink_chromium.org, nektarios, dmazzoni, apavlov+blink_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, devtools-reviews_chromium.org, blink-reviews, je_julie, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: extract ObjectUI module from Components BUG=687641 Review-Url: https://codereview.chromium.org/2712513002 Cr-Commit-Position: refs/heads/master@{#451975} Committed: https://chromium.googlesource.com/chromium/src/+/6133b51e341dcc55a1b43eebc51ffee3cd0979b8

Patch Set 1 #

Patch Set 2 : fix build.gn #

Unified diffs Side-by-side diffs Delta from patch set Stats (+233 lines, -2903 lines) Patch
M third_party/WebKit/LayoutTests/http/tests/inspector/console-cd-completions.html View 5 chunks +5 lines, -5 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/inspector/console-completions.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/inspector/console-test.js View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/console/console-big-array.html View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/console/console-dir-global.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/inspector/initial-modules-load-expected.txt View 5 chunks +5 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/local-object-properties-section.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/inspector/open-with-rendering-option-enabled-expected.txt View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/sources/debugger-ui/show-function-definition.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/inspector/sources/debugger/debugger-completions-on-call-frame.html View 1 chunk +13 lines, -13 lines 0 comments Download
M third_party/WebKit/Source/devtools/BUILD.gn View 1 2 chunks +9 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/Runtime.js View 1 chunk +4 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/accessibility/AccessibilitySidebarView.js View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/audits/AuditExtensionCategory.js View 1 chunk +1 line, -1 line 0 comments Download
D third_party/WebKit/Source/devtools/front_end/components/CustomPreviewComponent.js View 1 chunk +0 lines, -241 lines 0 comments Download
D third_party/WebKit/Source/devtools/front_end/components/JavaScriptAutocomplete.js View 1 chunk +0 lines, -469 lines 0 comments Download
D third_party/WebKit/Source/devtools/front_end/components/ObjectPopoverHelper.js View 1 chunk +0 lines, -200 lines 0 comments Download
D third_party/WebKit/Source/devtools/front_end/components/ObjectPropertiesSection.js View 1 chunk +0 lines, -1354 lines 0 comments Download
D third_party/WebKit/Source/devtools/front_end/components/RemoteObjectPreviewFormatter.js View 1 chunk +0 lines, -250 lines 0 comments Download
D third_party/WebKit/Source/devtools/front_end/components/customPreviewComponent.css View 1 chunk +0 lines, -21 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/components/module.json View 1 chunk +1 line, -9 lines 0 comments Download
D third_party/WebKit/Source/devtools/front_end/components/objectPropertiesSection.css View 1 chunk +0 lines, -58 lines 0 comments Download
D third_party/WebKit/Source/devtools/front_end/components/objectValue.css View 1 chunk +0 lines, -104 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/console/ConsolePrompt.js View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/console/ConsoleViewMessage.js View 8 chunks +8 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/console/module.json View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/elements/PropertiesWidget.js View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/event_listeners/EventListenersView.js View 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/event_listeners/module.json View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/extensions/ExtensionPanel.js View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/extensions/module.json View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/inspector.json View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/network/JSONView.js View 4 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/network/RequestHeadersView.js View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/network/module.json View 1 chunk +2 lines, -1 line 0 comments Download
A + third_party/WebKit/Source/devtools/front_end/object_ui/CustomPreviewComponent.js View 6 chunks +10 lines, -10 lines 0 comments Download
A + third_party/WebKit/Source/devtools/front_end/object_ui/JavaScriptAutocomplete.js View 9 chunks +15 lines, -15 lines 0 comments Download
A + third_party/WebKit/Source/devtools/front_end/object_ui/ObjectPopoverHelper.js View 8 chunks +10 lines, -10 lines 0 comments Download
A + third_party/WebKit/Source/devtools/front_end/object_ui/ObjectPropertiesSection.js View 36 chunks +68 lines, -70 lines 0 comments Download
A + third_party/WebKit/Source/devtools/front_end/object_ui/RemoteObjectPreviewFormatter.js View 3 chunks +3 lines, -3 lines 0 comments Download
A + third_party/WebKit/Source/devtools/front_end/object_ui/customPreviewComponent.css View 0 chunks +-1 lines, --1 lines 0 comments Download
A third_party/WebKit/Source/devtools/front_end/object_ui/module.json View 1 chunk +20 lines, -0 lines 0 comments Download
A + third_party/WebKit/Source/devtools/front_end/object_ui/objectPropertiesSection.css View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/Source/devtools/front_end/object_ui/objectValue.css View 0 chunks +-1 lines, --1 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/profiler/HeapSnapshotView.js View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/profiler/ProfilesPanel.js View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/profiler/module.json View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/resources/IndexedDBViews.js View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/resources/module.json View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sources/JavaScriptSourceFrame.js View 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sources/ScopeChainSidebarPane.js View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sources/WatchExpressionsSidebarPane.js View 6 chunks +7 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sources/module.json View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/scripts/extract_module/extract_module.js View 3 chunks +11 lines, -11 lines 0 comments Download
M third_party/WebKit/Source/devtools/scripts/special_case_namespaces.json View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 22 (12 generated)
chenwilliam
ptal.
3 years, 10 months ago (2017-02-21 20:24:09 UTC) #2
pfeldman
lgtm
3 years, 10 months ago (2017-02-21 21:53:34 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2712513002/20001
3 years, 10 months ago (2017-02-21 23:13:26 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: chromeos_amd64-generic_chromium_compile_only_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) linux_chromium_chromeos_ozone_rel_ng on ...
3 years, 10 months ago (2017-02-22 01:19:24 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2712513002/20001
3 years, 10 months ago (2017-02-22 01:54:30 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: chromeos_amd64-generic_chromium_compile_only_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) chromium_presubmit on ...
3 years, 10 months ago (2017-02-22 03:58:07 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2712513002/20001
3 years, 10 months ago (2017-02-22 04:48:55 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/369706)
3 years, 10 months ago (2017-02-22 07:41:49 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2712513002/20001
3 years, 10 months ago (2017-02-22 09:09:31 UTC) #19
commit-bot: I haz the power
3 years, 10 months ago (2017-02-22 10:28:57 UTC) #22
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/6133b51e341dcc55a1b43eebc51f...

Powered by Google App Engine
This is Rietveld 408576698