third_party/WebKit/Source/devtools/front_end/object_ui/RemoteObjectPreviewFormatter.js - Issue 2712513002: DevTools: extract ObjectUI module from Components

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/object_ui/RemoteObjectPreviewFormatter.js

Issue 2712513002: DevTools: extract ObjectUI module from Components (Closed)

Patch Set: fix build.gn Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/object_ui/ObjectPropertiesSection.js ('k') | third_party/WebKit/Source/devtools/front_end/object_ui/customPreviewComponent.css » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/object_ui/RemoteObjectPreviewFormatter.js

diff --git a/third_party/WebKit/Source/devtools/front_end/components/RemoteObjectPreviewFormatter.js b/third_party/WebKit/Source/devtools/front_end/object_ui/RemoteObjectPreviewFormatter.js

similarity index 96%

rename from third_party/WebKit/Source/devtools/front_end/components/RemoteObjectPreviewFormatter.js

rename to third_party/WebKit/Source/devtools/front_end/object_ui/RemoteObjectPreviewFormatter.js

index 8266ac35ff4630a2c876aaf51b6610579a4786f6..cc2234f9a834ff8b48616fec293d7e3fd8c1f0d4 100644

--- a/third_party/WebKit/Source/devtools/front_end/components/RemoteObjectPreviewFormatter.js

+++ b/third_party/WebKit/Source/devtools/front_end/object_ui/RemoteObjectPreviewFormatter.js

@@ -4,7 +4,7 @@

/**

* @unrestricted

-Components.RemoteObjectPreviewFormatter = class {

+ObjectUI.RemoteObjectPreviewFormatter = class {

/**

* @param {!Protocol.Runtime.PropertyPreview} a

* @param {!Protocol.Runtime.PropertyPreview} b

@@ -77,7 +77,7 @@ Components.RemoteObjectPreviewFormatter = class {

_appendObjectPropertiesPreview(parentElement, preview) {

var properties = preview.properties.filter(p => p.type !== 'accessor')

- .stableSort(Components.RemoteObjectPreviewFormatter._objectPropertyComparator);

+ .stableSort(ObjectUI.RemoteObjectPreviewFormatter._objectPropertyComparator);

for (var i = 0; i < properties.length; ++i) {

if (i > 0)

parentElement.createTextChild(', ');

@@ -97,7 +97,7 @@ Components.RemoteObjectPreviewFormatter = class {

var arrayLength = SDK.RemoteObject.arrayLength(preview);

var indexProperties = preview.properties.filter(p => toArrayIndex(p.name) !== -1).stableSort(arrayEntryComparator);

var otherProperties = preview.properties.filter(p => toArrayIndex(p.name) === -1)

- .stableSort(Components.RemoteObjectPreviewFormatter._objectPropertyComparator);

+ .stableSort(ObjectUI.RemoteObjectPreviewFormatter._objectPropertyComparator);

/**

* @param {!Protocol.Runtime.PropertyPreview} a