Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(115)

Unified Diff: third_party/WebKit/Source/devtools/scripts/extract_module/extract_module.js

Issue 2712513002: DevTools: extract ObjectUI module from Components (Closed)
Patch Set: fix build.gn Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/scripts/extract_module/extract_module.js
diff --git a/third_party/WebKit/Source/devtools/scripts/extract_module/extract_module.js b/third_party/WebKit/Source/devtools/scripts/extract_module/extract_module.js
index 317185038c919e7ff6eb1fd706dc5ffaf4179527..307f117793c6c8e24b0a9fce742309a6e2ab143b 100644
--- a/third_party/WebKit/Source/devtools/scripts/extract_module/extract_module.js
+++ b/third_party/WebKit/Source/devtools/scripts/extract_module/extract_module.js
@@ -24,17 +24,19 @@ const APPLICATION_DESCRIPTORS = [
const MODULES_TO_REMOVE = [];
const JS_FILES_MAPPING = [
- {file: 'components/EventListenersView.js', new: 'event_listeners'},
- {file: 'components/EventListenersUtils.js', new: 'event_listeners'},
- // {file: 'module/file.js', existing: 'module'}
+ {file: 'components/CustomPreviewComponent.js', new: 'object_ui'},
+ {file: 'components/ObjectPopoverHelper.js', new: 'object_ui'},
+ {file: 'components/ObjectPropertiesSection.js', new: 'object_ui'},
+ {file: 'components/JavaScriptAutocomplete.js', new: 'object_ui'},
+ {file: 'components/RemoteObjectPreviewFormatter.js', new: 'object_ui'},
];
const MODULE_MAPPING = {
- event_listeners: {
- dependencies: ['ui', 'common', 'components', 'sdk'],
- dependents: ['elements', 'sources'],
+ object_ui: {
+ dependencies: ['ui', 'sdk', 'components'],
+ dependents: ['console', 'sources', 'extensions', 'event_listeners', 'resources', 'profiler', 'network'],
applications: ['inspector.json'],
- autostart: false,
+ autostart: true, // set to autostart because of extensions
},
};
@@ -74,8 +76,6 @@ function extractModule() {
}, new Map());
const cssFilesMapping = findCSSFiles();
- // todo: one-off
- cssFilesMapping.get('components/EventListenersView.js').delete('objectValue.css');
console.log('cssFilesMapping', cssFilesMapping);
const identifiersByFile = calculateIdentifiers();
const identifierMap = mapIdentifiers(identifiersByFile, cssFilesMapping);
@@ -289,8 +289,8 @@ function updateBuildGNFile(cssFilesMapping, newModuleSet) {
continue;
const nextContent = top(contentStack) ? top(contentStack).toLowerCase() : '';
- if ((line === startLine || nextContent > line.toLowerCase()) &&
- (nextLine === endLine || nextContent < nextLine.toLowerCase()))
+ if ((line === startLine || nextContent >= line.toLowerCase()) &&
+ (nextLine === endLine || nextContent <= nextLine.toLowerCase()))
lines.splice(i + 1, 0, contentStack.pop());
}
if (contentStack.length)

Powered by Google App Engine
This is Rietveld 408576698