Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(678)

Unified Diff: third_party/WebKit/Source/devtools/front_end/object_ui/ObjectPopoverHelper.js

Issue 2712513002: DevTools: extract ObjectUI module from Components (Closed)
Patch Set: fix build.gn Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/object_ui/ObjectPopoverHelper.js
diff --git a/third_party/WebKit/Source/devtools/front_end/components/ObjectPopoverHelper.js b/third_party/WebKit/Source/devtools/front_end/object_ui/ObjectPopoverHelper.js
similarity index 91%
rename from third_party/WebKit/Source/devtools/front_end/components/ObjectPopoverHelper.js
rename to third_party/WebKit/Source/devtools/front_end/object_ui/ObjectPopoverHelper.js
index be78fcf66d4ac57ce1a2e18ac6fbf14b3f43a38d..29773797b0d28cfdf828b8c39c13846066828ee0 100644
--- a/third_party/WebKit/Source/devtools/front_end/components/ObjectPopoverHelper.js
+++ b/third_party/WebKit/Source/devtools/front_end/object_ui/ObjectPopoverHelper.js
@@ -31,7 +31,7 @@
/**
* @unrestricted
*/
-Components.ObjectPopoverHelper = class extends UI.PopoverHelper {
+ObjectUI.ObjectPopoverHelper = class extends UI.PopoverHelper {
/**
* @param {!Element} panelElement
* @param {function(!Element, !Event):(!Element|!AnchorBox|undefined)} getAnchor
@@ -60,7 +60,7 @@ Components.ObjectPopoverHelper = class extends UI.PopoverHelper {
* @param {!Element} anchorElement
* @param {?Array.<!SDK.RemoteObjectProperty>} properties
* @param {?Array.<!SDK.RemoteObjectProperty>} internalProperties
- * @this {Components.ObjectPopoverHelper}
+ * @this {ObjectUI.ObjectPopoverHelper}
*/
function didGetFunctionProperties(
funcObject, popoverContentElement, popoverValueElement, anchorElement, properties, internalProperties) {
@@ -72,7 +72,7 @@ Components.ObjectPopoverHelper = class extends UI.PopoverHelper {
}
}
}
- Components.ObjectPropertiesSection.formatObjectAsFunction(funcObject, popoverValueElement, true);
+ ObjectUI.ObjectPropertiesSection.formatObjectAsFunction(funcObject, popoverValueElement, true);
funcObject.debuggerModel()
.functionDetailsPromise(funcObject)
.then(didGetFunctionDetails.bind(this, popoverContentElement, anchorElement));
@@ -82,7 +82,7 @@ Components.ObjectPopoverHelper = class extends UI.PopoverHelper {
* @param {!Element} popoverContentElement
* @param {!Element} anchorElement
* @param {?SDK.DebuggerModel.FunctionDetails} response
- * @this {Components.ObjectPopoverHelper}
+ * @this {ObjectUI.ObjectPopoverHelper}
*/
function didGetFunctionDetails(popoverContentElement, anchorElement, response) {
if (!response || popover.disposed)
@@ -112,7 +112,7 @@ Components.ObjectPopoverHelper = class extends UI.PopoverHelper {
* @param {!SDK.RemoteObject} result
* @param {boolean} wasThrown
* @param {!Element=} anchorOverride
- * @this {Components.ObjectPopoverHelper}
+ * @this {ObjectUI.ObjectPopoverHelper}
*/
function didQueryObject(result, wasThrown, anchorOverride) {
if (popover.disposed)
@@ -123,11 +123,11 @@ Components.ObjectPopoverHelper = class extends UI.PopoverHelper {
}
this._objectTarget = result.target();
var anchorElement = anchorOverride || element;
- var description = result.description.trimEnd(Components.ObjectPopoverHelper.MaxPopoverTextLength);
+ var description = result.description.trimEnd(ObjectUI.ObjectPopoverHelper.MaxPopoverTextLength);
var popoverContentElement = null;
if (result.type !== 'object') {
popoverContentElement = createElement('span');
- UI.appendStyle(popoverContentElement, 'components/objectValue.css');
+ UI.appendStyle(popoverContentElement, 'object_ui/objectValue.css');
var valueElement = popoverContentElement.createChild('span', 'monospace object-value-' + result.type);
valueElement.style.whiteSpace = 'pre';
@@ -150,14 +150,14 @@ Components.ObjectPopoverHelper = class extends UI.PopoverHelper {
}
if (result.customPreview()) {
- var customPreviewComponent = new Components.CustomPreviewComponent(result);
+ var customPreviewComponent = new ObjectUI.CustomPreviewComponent(result);
customPreviewComponent.expandIfPossible();
popoverContentElement = customPreviewComponent.element;
} else {
popoverContentElement = createElement('div');
this._titleElement = popoverContentElement.createChild('div', 'monospace');
this._titleElement.createChild('span', 'source-frame-popover-title').textContent = description;
- var section = new Components.ObjectPropertiesSection(result, '', this._lazyLinkifier());
+ var section = new ObjectUI.ObjectPropertiesSection(result, '', this._lazyLinkifier());
section.element.classList.add('source-frame-popover-tree');
section.titleLessMode();
popoverContentElement.appendChild(section.element);
@@ -197,4 +197,4 @@ Components.ObjectPopoverHelper = class extends UI.PopoverHelper {
}
};
-Components.ObjectPopoverHelper.MaxPopoverTextLength = 10000;
+ObjectUI.ObjectPopoverHelper.MaxPopoverTextLength = 10000;

Powered by Google App Engine
This is Rietveld 408576698