Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(359)

Unified Diff: third_party/WebKit/Source/devtools/front_end/sources/JavaScriptSourceFrame.js

Issue 2712513002: DevTools: extract ObjectUI module from Components (Closed)
Patch Set: fix build.gn Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/sources/JavaScriptSourceFrame.js
diff --git a/third_party/WebKit/Source/devtools/front_end/sources/JavaScriptSourceFrame.js b/third_party/WebKit/Source/devtools/front_end/sources/JavaScriptSourceFrame.js
index 89ab2af7f7ff62737b54e7c00904cc5bbf016e34..fc995436fdb9683804b8e7c71ee265ff07059aa7 100644
--- a/third_party/WebKit/Source/devtools/front_end/sources/JavaScriptSourceFrame.js
+++ b/third_party/WebKit/Source/devtools/front_end/sources/JavaScriptSourceFrame.js
@@ -44,7 +44,7 @@ Sources.JavaScriptSourceFrame = class extends SourceFrame.UISourceCodeFrame {
if (uiSourceCode.project().type() === Workspace.projectTypes.Debugger)
this.element.classList.add('source-frame-debugger-script');
- this._popoverHelper = new Components.ObjectPopoverHelper(
+ this._popoverHelper = new ObjectUI.ObjectPopoverHelper(
this._scriptsPanel.element, this._getPopoverAnchor.bind(this), this._resolveObjectForPopover.bind(this),
this._onHidePopover.bind(this), true);
this._popoverHelper.setTimeout(250, 250);
@@ -655,7 +655,7 @@ Sources.JavaScriptSourceFrame = class extends SourceFrame.UISourceCodeFrame {
* @param {number} toLine
*/
_renderDecorations(valuesMap, namesPerLine, fromLine, toLine) {
- var formatter = new Components.RemoteObjectPreviewFormatter();
+ var formatter = new ObjectUI.RemoteObjectPreviewFormatter();
for (var i = fromLine; i < toLine; ++i) {
var names = namesPerLine.get(i);
var oldWidget = this._valueWidgets.get(i);
@@ -692,7 +692,7 @@ Sources.JavaScriptSourceFrame = class extends SourceFrame.UISourceCodeFrame {
if (value.preview && propertyCount + entryCount < 10) {
formatter.appendObjectPreview(nameValuePair, value.preview, false /* isEntry */);
} else {
- nameValuePair.appendChild(Components.ObjectPropertiesSection.createValueElement(
+ nameValuePair.appendChild(ObjectUI.ObjectPropertiesSection.createValueElement(
value, false /* wasThrown */, false /* showPreview */));
}
++renderedNameCount;

Powered by Google App Engine
This is Rietveld 408576698