third_party/WebKit/Source/devtools/front_end/event_listeners/EventListenersView.js - Issue 2712513002: DevTools: extract ObjectUI module from Components

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/event_listeners/EventListenersView.js

Issue 2712513002: DevTools: extract ObjectUI module from Components (Closed)

Patch Set: fix build.gn Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/elements/PropertiesWidget.js ('k') | third_party/WebKit/Source/devtools/front_end/event_listeners/module.json » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/event_listeners/EventListenersView.js

diff --git a/third_party/WebKit/Source/devtools/front_end/event_listeners/EventListenersView.js b/third_party/WebKit/Source/devtools/front_end/event_listeners/EventListenersView.js

index 55dde0c17a3c9771d76d8874c5fe2d778c0555a2..25c4ede2e62b6f575171ae311255496297b72eb6 100644

--- a/third_party/WebKit/Source/devtools/front_end/event_listeners/EventListenersView.js

+++ b/third_party/WebKit/Source/devtools/front_end/event_listeners/EventListenersView.js

@@ -19,7 +19,7 @@ EventListeners.EventListenersView = class {

this._changeCallback = changeCallback;

this._treeOutline = new UI.TreeOutlineInShadow();

this._treeOutline.hideOverflow();

- this._treeOutline.registerRequiredCSS('components/objectValue.css');

+ this._treeOutline.registerRequiredCSS('object_ui/objectValue.css');

this._treeOutline.registerRequiredCSS('event_listeners/eventListenersView.css');

this._treeOutline.setComparator(EventListeners.EventListenersTreeElement.comparator);

this._treeOutline.element.classList.add('monospace');

@@ -273,7 +273,7 @@ EventListeners.ObjectEventListenerBar = class extends UI.TreeElement {

properties.push(runtimeModel.createRemotePropertyFromPrimitiveValue('once', eventListener.once()));

if (typeof eventListener.handler() !== 'undefined')

properties.push(new SDK.RemoteObjectProperty('handler', eventListener.handler()));

- Components.ObjectPropertyTreeElement.populateWithProperties(this, properties, [], true, null);

+ ObjectUI.ObjectPropertyTreeElement.populateWithProperties(this, properties, [], true, null);

}

/**

@@ -286,7 +286,7 @@ EventListeners.ObjectEventListenerBar = class extends UI.TreeElement {

subtitle.appendChild(linkifier.linkifyRawLocation(this._eventListener.location(), this._eventListener.sourceURL()));

title.appendChild(

- Components.ObjectPropertiesSection.createValueElement(object, false /* wasThrown */, false /* showPreview */));

+ ObjectUI.ObjectPropertiesSection.createValueElement(object, false /* wasThrown */, false /* showPreview */));

if (this._eventListener.canRemove()) {

var deleteButton = title.createChild('span', 'event-listener-button');