Replace RTC_DCHECK(false) with RTC_NOTREACHED().

Replace RTC_DCHECK(false) with RTC_NOTREACHED().

Bulk of changes done using

  git grep -l 'RTC_DCHECK(false)' | \
    xargs sed -i 's/RTC_DCHECK(false)/RTC_NOTREACHED()/'

peerconnection.cc also used RTC_DCHECK(false && "msg") in two places,
which were updated manually.

BUG=webrtc:6424
Review-Url: https://codereview.webrtc.org/2623313004
Cr-Commit-Position: refs/heads/master@{#16026}
Committed: https://chromium.googlesource.com/external/webrtc/+/eb4ca4e8235c44537b18f8a91059b2da1b7227ff

[nisse-webrtc, 2017-01-12 08:02:19]

nisse@webrtc.org changed reviewers:
+ kwiberg@webrtc.org

[nisse-webrtc, 2017-01-12 08:02:20]

PTAL. I think it's best to do this before replacing ASSERT(false).

[nisse-webrtc, 2017-01-12 08:04:55]

And I guess RTC_CHECK(false) should also be converted to FATAL(), some other
time.

[kwiberg-webrtc, 2017-01-12 09:18:03]

lgtm

[nisse-webrtc, 2017-01-12 09:19:04]

The CQ bit was checked by nisse@webrtc.org

[commit-bot: I haz the power, 2017-01-12 09:19:13]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[kwiberg-webrtc, 2017-01-12 09:19:51]

On 2017/01/12 08:04:55, nisse-webrtc wrote:
> And I guess RTC_CHECK(false) should also be converted to FATAL(), some other
> time.

As I said in one of the other CLs, I think RTC_NOTREACHED should be renamed to
RTC_DCHECK_NOTREACHED (so that people won't have to remember if it behaves like
CHECK or DCHECK). And then it would make sense to have RTC_CHECK_NOTREACHED too.

[commit-bot: I haz the power, 2017-01-12 10:24:28]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1484212744736510, "parent_rev":
"295760daa187d30aa81f6cc5f7768538080c09f6", "commit_rev":
"eb4ca4e8235c44537b18f8a91059b2da1b7227ff"}

[commit-bot: I haz the power, 2017-01-12 10:24:34]

Description was changed from

==========
Replace RTC_DCHECK(false) with RTC_NOTREACHED().

Bulk of changes done using

  git grep -l 'RTC_DCHECK(false)' | \
    xargs sed -i 's/RTC_DCHECK(false)/RTC_NOTREACHED()/'

peerconnection.cc also used RTC_DCHECK(false && "msg") in two places,
which were updated manually.

BUG=webrtc:6424
==========

to

==========
Replace RTC_DCHECK(false) with RTC_NOTREACHED().

Bulk of changes done using

  git grep -l 'RTC_DCHECK(false)' | \
    xargs sed -i 's/RTC_DCHECK(false)/RTC_NOTREACHED()/'

peerconnection.cc also used RTC_DCHECK(false && "msg") in two places,
which were updated manually.

BUG=webrtc:6424

Review-Url: https://codereview.webrtc.org/2623313004
Cr-Commit-Position: refs/heads/master@{#16026}
Committed:
https://chromium.googlesource.com/external/webrtc/+/eb4ca4e8235c44537b18f8a91...
==========

[commit-bot: I haz the power, 2017-01-12 10:24:35]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/eb4ca4e8235c44537b18f8a91...