Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(494)

Side by Side Diff: webrtc/api/webrtcsession.cc

Issue 2623313004: Replace RTC_DCHECK(false) with RTC_NOTREACHED(). (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « webrtc/api/statstypes.cc ('k') | webrtc/base/network.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright 2012 The WebRTC project authors. All Rights Reserved. 2 * Copyright 2012 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
(...skipping 393 matching lines...) Expand 10 before | Expand all | Expand 10 after
404 result = #err; \ 404 result = #err; \
405 break; 405 break;
406 406
407 static std::string GetErrorCodeString(webrtc::WebRtcSession::Error err) { 407 static std::string GetErrorCodeString(webrtc::WebRtcSession::Error err) {
408 std::string result; 408 std::string result;
409 switch (err) { 409 switch (err) {
410 GET_STRING_OF_ERROR_CODE(ERROR_NONE) 410 GET_STRING_OF_ERROR_CODE(ERROR_NONE)
411 GET_STRING_OF_ERROR_CODE(ERROR_CONTENT) 411 GET_STRING_OF_ERROR_CODE(ERROR_CONTENT)
412 GET_STRING_OF_ERROR_CODE(ERROR_TRANSPORT) 412 GET_STRING_OF_ERROR_CODE(ERROR_TRANSPORT)
413 default: 413 default:
414 RTC_DCHECK(false); 414 RTC_NOTREACHED();
415 break; 415 break;
416 } 416 }
417 return result; 417 return result;
418 } 418 }
419 419
420 static std::string MakeErrorString(const std::string& error, 420 static std::string MakeErrorString(const std::string& error,
421 const std::string& desc) { 421 const std::string& desc) {
422 std::ostringstream ret; 422 std::ostringstream ret;
423 ret << error << " " << desc; 423 ret << error << " " << desc;
424 return ret.str(); 424 return ret.str();
(...skipping 760 matching lines...) Expand 10 before | Expand all | Expand 10 after
1185 // TODO(honghaiz): Add the third continual gathering policy in 1185 // TODO(honghaiz): Add the third continual gathering policy in
1186 // PeerConnectionInterface and map it to GATHER_CONTINUALLY_AND_RECOVER. 1186 // PeerConnectionInterface and map it to GATHER_CONTINUALLY_AND_RECOVER.
1187 switch (config.continual_gathering_policy) { 1187 switch (config.continual_gathering_policy) {
1188 case PeerConnectionInterface::GATHER_ONCE: 1188 case PeerConnectionInterface::GATHER_ONCE:
1189 gathering_policy = cricket::GATHER_ONCE; 1189 gathering_policy = cricket::GATHER_ONCE;
1190 break; 1190 break;
1191 case PeerConnectionInterface::GATHER_CONTINUALLY: 1191 case PeerConnectionInterface::GATHER_CONTINUALLY:
1192 gathering_policy = cricket::GATHER_CONTINUALLY; 1192 gathering_policy = cricket::GATHER_CONTINUALLY;
1193 break; 1193 break;
1194 default: 1194 default:
1195 RTC_DCHECK(false); 1195 RTC_NOTREACHED();
1196 gathering_policy = cricket::GATHER_ONCE; 1196 gathering_policy = cricket::GATHER_ONCE;
1197 } 1197 }
1198 cricket::IceConfig ice_config; 1198 cricket::IceConfig ice_config;
1199 ice_config.receiving_timeout = config.ice_connection_receiving_timeout; 1199 ice_config.receiving_timeout = config.ice_connection_receiving_timeout;
1200 ice_config.prioritize_most_likely_candidate_pairs = 1200 ice_config.prioritize_most_likely_candidate_pairs =
1201 config.prioritize_most_likely_ice_candidate_pairs; 1201 config.prioritize_most_likely_ice_candidate_pairs;
1202 ice_config.backup_connection_ping_interval = 1202 ice_config.backup_connection_ping_interval =
1203 config.ice_backup_candidate_pair_ping_interval; 1203 config.ice_backup_candidate_pair_ping_interval;
1204 ice_config.continual_gathering_policy = gathering_policy; 1204 ice_config.continual_gathering_policy = gathering_policy;
1205 ice_config.presume_writable_when_fully_relayed = 1205 ice_config.presume_writable_when_fully_relayed =
(...skipping 1106 matching lines...) Expand 10 before | Expand all | Expand 10 after
2312 return *sctp_transport_name_; 2312 return *sctp_transport_name_;
2313 } 2313 }
2314 } 2314 }
2315 // Return an empty string if failed to retrieve the transport name. 2315 // Return an empty string if failed to retrieve the transport name.
2316 return ""; 2316 return "";
2317 } 2317 }
2318 return channel->transport_name(); 2318 return channel->transport_name();
2319 } 2319 }
2320 2320
2321 } // namespace webrtc 2321 } // namespace webrtc
OLDNEW
« no previous file with comments | « webrtc/api/statstypes.cc ('k') | webrtc/base/network.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698