Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(309)

Side by Side Diff: webrtc/api/rtpsender.cc

Issue 2623313004: Replace RTC_DCHECK(false) with RTC_NOTREACHED(). (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « webrtc/api/rtpreceiver.cc ('k') | webrtc/api/statscollector.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright 2015 The WebRTC project authors. All Rights Reserved. 2 * Copyright 2015 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
(...skipping 370 matching lines...) Expand 10 before | Expand all | Expand 10 after
381 case VideoTrackInterface::ContentHint::kNone: 381 case VideoTrackInterface::ContentHint::kNone:
382 break; 382 break;
383 case VideoTrackInterface::ContentHint::kFluid: 383 case VideoTrackInterface::ContentHint::kFluid:
384 options.is_screencast = rtc::Optional<bool>(false); 384 options.is_screencast = rtc::Optional<bool>(false);
385 break; 385 break;
386 case VideoTrackInterface::ContentHint::kDetailed: 386 case VideoTrackInterface::ContentHint::kDetailed:
387 options.is_screencast = rtc::Optional<bool>(true); 387 options.is_screencast = rtc::Optional<bool>(true);
388 break; 388 break;
389 } 389 }
390 if (!channel_->SetVideoSend(ssrc_, track_->enabled(), &options, track_)) { 390 if (!channel_->SetVideoSend(ssrc_, track_->enabled(), &options, track_)) {
391 RTC_DCHECK(false); 391 RTC_NOTREACHED();
392 } 392 }
393 } 393 }
394 394
395 void VideoRtpSender::ClearVideoSend() { 395 void VideoRtpSender::ClearVideoSend() {
396 RTC_DCHECK(ssrc_ != 0); 396 RTC_DCHECK(ssrc_ != 0);
397 RTC_DCHECK(!stopped_); 397 RTC_DCHECK(!stopped_);
398 if (!channel_) { 398 if (!channel_) {
399 LOG(LS_WARNING) << "SetVideoSend: No video channel exists."; 399 LOG(LS_WARNING) << "SetVideoSend: No video channel exists.";
400 return; 400 return;
401 } 401 }
402 // Allow SetVideoSend to fail since |enable| is false and |source| is null. 402 // Allow SetVideoSend to fail since |enable| is false and |source| is null.
403 // This the normal case when the underlying media channel has already been 403 // This the normal case when the underlying media channel has already been
404 // deleted. 404 // deleted.
405 channel_->SetVideoSend(ssrc_, false, nullptr, nullptr); 405 channel_->SetVideoSend(ssrc_, false, nullptr, nullptr);
406 } 406 }
407 407
408 } // namespace webrtc 408 } // namespace webrtc
OLDNEW
« no previous file with comments | « webrtc/api/rtpreceiver.cc ('k') | webrtc/api/statscollector.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698