Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(59)

Side by Side Diff: webrtc/api/statstypes.cc

Issue 2623313004: Replace RTC_DCHECK(false) with RTC_NOTREACHED(). (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « webrtc/api/statscollector.cc ('k') | webrtc/api/webrtcsession.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright 2014 The WebRTC project authors. All Rights Reserved. 2 * Copyright 2014 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
(...skipping 39 matching lines...) Expand 10 before | Expand all | Expand 10 after
50 return "transport"; 50 return "transport";
51 case StatsReport::kStatsReportTypeComponent: 51 case StatsReport::kStatsReportTypeComponent:
52 return "googComponent"; 52 return "googComponent";
53 case StatsReport::kStatsReportTypeCandidatePair: 53 case StatsReport::kStatsReportTypeCandidatePair:
54 return "googCandidatePair"; 54 return "googCandidatePair";
55 case StatsReport::kStatsReportTypeCertificate: 55 case StatsReport::kStatsReportTypeCertificate:
56 return "googCertificate"; 56 return "googCertificate";
57 case StatsReport::kStatsReportTypeDataChannel: 57 case StatsReport::kStatsReportTypeDataChannel:
58 return "datachannel"; 58 return "datachannel";
59 } 59 }
60 RTC_DCHECK(false); 60 RTC_NOTREACHED();
61 return nullptr; 61 return nullptr;
62 } 62 }
63 63
64 class BandwidthEstimationId : public StatsReport::IdBase { 64 class BandwidthEstimationId : public StatsReport::IdBase {
65 public: 65 public:
66 BandwidthEstimationId() 66 BandwidthEstimationId()
67 : StatsReport::IdBase(StatsReport::kStatsReportTypeBwe) {} 67 : StatsReport::IdBase(StatsReport::kStatsReportTypeBwe) {}
68 std::string ToString() const override { return kStatsReportVideoBweId; } 68 std::string ToString() const override { return kStatsReportVideoBweId; }
69 }; 69 };
70 70
(...skipping 707 matching lines...) Expand 10 before | Expand all | Expand 10 after
778 // Looks for a report with the given |id|. If one is not found, NULL 778 // Looks for a report with the given |id|. If one is not found, NULL
779 // will be returned. 779 // will be returned.
780 StatsReport* StatsCollection::Find(const StatsReport::Id& id) { 780 StatsReport* StatsCollection::Find(const StatsReport::Id& id) {
781 RTC_DCHECK(thread_checker_.CalledOnValidThread()); 781 RTC_DCHECK(thread_checker_.CalledOnValidThread());
782 Container::iterator it = std::find_if(list_.begin(), list_.end(), 782 Container::iterator it = std::find_if(list_.begin(), list_.end(),
783 [&id](const StatsReport* r)->bool { return r->id()->Equals(id); }); 783 [&id](const StatsReport* r)->bool { return r->id()->Equals(id); });
784 return it == list_.end() ? nullptr : *it; 784 return it == list_.end() ? nullptr : *it;
785 } 785 }
786 786
787 } // namespace webrtc 787 } // namespace webrtc
OLDNEW
« no previous file with comments | « webrtc/api/statscollector.cc ('k') | webrtc/api/webrtcsession.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698