Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2472)

Unified Diff: webrtc/api/peerconnection.cc

Issue 2623313004: Replace RTC_DCHECK(false) with RTC_NOTREACHED(). (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | webrtc/api/quicdatachannel.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/api/peerconnection.cc
diff --git a/webrtc/api/peerconnection.cc b/webrtc/api/peerconnection.cc
index 2f21e0c468adfc1cc3ac889d1320383cdf1f495a..1a29e5512493e1761e9c55f7e3eeed6aa94747c5 100644
--- a/webrtc/api/peerconnection.cc
+++ b/webrtc/api/peerconnection.cc
@@ -327,7 +327,7 @@ RTCErrorType ParseIceServerUrl(
default:
// We shouldn't get to this point with an invalid service_type, we should
// have returned an error already.
- RTC_DCHECK(false) << "Unexpected service type";
+ RTC_NOTREACHED() << "Unexpected service type";
return RTCErrorType::INTERNAL_ERROR;
}
return RTCErrorType::NONE;
@@ -548,7 +548,7 @@ std::string GenerateRtcpCname() {
std::string cname;
if (!rtc::CreateRandomString(kRtcpCnameLength, &cname)) {
LOG(LS_ERROR) << "Failed to generate CNAME.";
- RTC_DCHECK(false);
+ RTC_NOTREACHED();
}
return cname;
}
@@ -1617,7 +1617,7 @@ void PeerConnection::OnMessage(rtc::Message* msg) {
break;
}
default:
- RTC_DCHECK(false && "Not implemented");
+ RTC_NOTREACHED() << "Not implemented";
break;
}
}
@@ -2042,7 +2042,7 @@ void PeerConnection::OnRemoteTrackSeen(const std::string& stream_label,
} else if (media_type == cricket::MEDIA_TYPE_VIDEO) {
CreateVideoReceiver(stream, track_id, ssrc);
} else {
- RTC_DCHECK(false && "Invalid media type");
+ RTC_NOTREACHED() << "Invalid media type";
}
}
« no previous file with comments | « no previous file | webrtc/api/quicdatachannel.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698