Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(146)

Unified Diff: webrtc/api/rtpreceiver.cc

Issue 2623313004: Replace RTC_DCHECK(false) with RTC_NOTREACHED(). (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webrtc/api/quicdatatransport.cc ('k') | webrtc/api/rtpsender.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/api/rtpreceiver.cc
diff --git a/webrtc/api/rtpreceiver.cc b/webrtc/api/rtpreceiver.cc
index 80a0256a02b8c6c802ec5bd73da0ce98a80f0879..a5a764c048eb6fe1f836840e468b5816d3f25486 100644
--- a/webrtc/api/rtpreceiver.cc
+++ b/webrtc/api/rtpreceiver.cc
@@ -66,7 +66,7 @@ void AudioRtpReceiver::OnSetVolume(double volume) {
// setting the volume to the source when the track is disabled.
if (!stopped_ && track_->enabled()) {
if (!channel_->SetOutputVolume(ssrc_, cached_volume_)) {
- RTC_DCHECK(false);
+ RTC_NOTREACHED();
}
}
}
@@ -107,7 +107,7 @@ void AudioRtpReceiver::Reconfigure() {
}
if (!channel_->SetOutputVolume(ssrc_,
track_->enabled() ? cached_volume_ : 0)) {
- RTC_DCHECK(false);
+ RTC_NOTREACHED();
}
}
@@ -161,7 +161,7 @@ VideoRtpReceiver::VideoRtpReceiver(MediaStreamInterface* stream,
<< "VideoRtpReceiver::VideoRtpReceiver: No video channel exists.";
} else {
if (!channel_->SetSink(ssrc_, &broadcaster_)) {
- RTC_DCHECK(false);
+ RTC_NOTREACHED();
}
}
stream->AddTrack(track_);
@@ -225,7 +225,7 @@ void VideoRtpReceiver::SetChannel(cricket::VideoChannel* channel) {
channel_ = channel;
if (channel_) {
if (!channel_->SetSink(ssrc_, &broadcaster_)) {
- RTC_DCHECK(false);
+ RTC_NOTREACHED();
}
channel_->SignalFirstPacketReceived.connect(
this, &VideoRtpReceiver::OnFirstPacketReceived);
« no previous file with comments | « webrtc/api/quicdatatransport.cc ('k') | webrtc/api/rtpsender.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698