Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Issue 2535593002: RTC_[D]CHECK_op: Remove "u" suffix on integer constants (Closed)

Created:
4 years ago by kwiberg-webrtc
Modified:
4 years ago
Reviewers:
ossu
CC:
webrtc-reviews_webrtc.org, video-team_agora.io, danilchap, yujie_mao (webrtc), kwiberg-webrtc, sdk-team_agora.io, Andrew MacDonald, zhuangzesen_agora.io, henrika_webrtc, stefan-webrtc, tlegrand-webrtc, tterriberry_mozilla.com, audio-team_agora.io, hlundin-webrtc, mflodman, peah-webrtc, minyue-webrtc, the sun, fengyue_agora.io, zhengzhonghou_agora.io, aluebs-webrtc, bjornv1
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

RTC_[D]CHECK_op: Remove "u" suffix on integer constants There's no longer any need to make the two arguments have the same signedness, so we can drop the "u" suffix on literal integer arguments. NOPRESUBMIT=true BUG=webrtc:6645 Committed: https://crrev.com/af476c737fe008a185a99144731fd398e311ba65 Cr-Commit-Position: refs/heads/master@{#15280}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+167 lines, -167 lines) Patch
M webrtc/audio/audio_transport_proxy.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M webrtc/base/bitbuffer.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M webrtc/base/filerotatingstream.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M webrtc/base/flags.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/call/bitrate_allocator.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M webrtc/call/bitrate_estimator_tests.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/call/call_perf_tests.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/common_audio/audio_converter.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/common_audio/channel_buffer.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/common_audio/include/audio_util.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/common_audio/lapped_transform.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M webrtc/common_audio/resampler/push_resampler.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M webrtc/common_audio/sparse_fir_filter.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M webrtc/common_audio/wav_file.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M webrtc/media/engine/webrtcvideoengine2.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M webrtc/modules/audio_coding/acm2/audio_coding_module.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/audio_coding/acm2/codec_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/audio_coding/codecs/cng/audio_encoder_cng.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M webrtc/modules/audio_coding/codecs/g711/audio_decoder_pcm.h View 2 chunks +2 lines, -2 lines 0 comments Download
M webrtc/modules/audio_coding/codecs/ilbc/audio_decoder_ilbc.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/audio_coding/codecs/opus/audio_encoder_opus.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/audio_coding/codecs/opus/audio_encoder_opus_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/audio_coding/codecs/pcm16b/audio_decoder_pcm16b.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/audio_coding/codecs/red/audio_encoder_copy_red.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M webrtc/modules/audio_coding/neteq/delay_peak_detector.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/audio_coding/neteq/nack_tracker.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/audio_coding/neteq/test/RTPencode.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/audio_coding/neteq/tools/encode_neteq_input.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/audio_coding/neteq/tools/fake_decode_from_file.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M webrtc/modules/audio_coding/neteq/tools/neteq_replacement_input.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/audio_device/android/opensles_player.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M webrtc/modules/audio_device/audio_device_buffer.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/audio_device/ios/audio_device_ios.mm View 1 chunk +2 lines, -2 lines 0 comments Download
M webrtc/modules/audio_mixer/audio_frame_manipulator.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M webrtc/modules/audio_processing/aec/aec_core.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M webrtc/modules/audio_processing/aec/aec_resampler.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/audio_processing/aecm/aecm_core_neon.cc View 2 chunks +6 lines, -6 lines 0 comments Download
M webrtc/modules/audio_processing/agc/agc.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/audio_processing/audio_buffer.cc View 1 chunk +5 lines, -5 lines 0 comments Download
M webrtc/modules/audio_processing/audio_processing_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/audio_processing/beamformer/array_util.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M webrtc/modules/audio_processing/beamformer/covariance_matrix_generator.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M webrtc/modules/audio_processing/beamformer/nonlinear_beamformer.cc View 4 chunks +5 lines, -5 lines 0 comments Download
M webrtc/modules/audio_processing/echo_cancellation_impl.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M webrtc/modules/audio_processing/echo_control_mobile_impl.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M webrtc/modules/audio_processing/gain_control_impl.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M webrtc/modules/audio_processing/intelligibility/intelligibility_enhancer.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M webrtc/modules/audio_processing/level_controller/level_controller.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M webrtc/modules/audio_processing/level_controller/noise_spectrum_estimator.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/audio_processing/level_controller/signal_classifier.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M webrtc/modules/audio_processing/low_cut_filter.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/audio_processing/noise_suppression_impl.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M webrtc/modules/audio_processing/residual_echo_detector.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/audio_processing/test/test_utils.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/audio_processing/transient/moving_moments.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/audio_processing/transient/wpd_node.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M webrtc/modules/audio_processing/voice_detection_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/pacing/bitrate_prober.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M webrtc/modules/pacing/paced_sender.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M webrtc/modules/remote_bitrate_estimator/remote_bitrate_estimator_unittest_helper.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/rtp_rtcp/source/forward_error_correction.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtcp_packet.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtcp_packet/app.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtcp_packet/bye.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtcp_packet/fir.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtcp_packet/remb.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtcp_packet/report_block.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtcp_packet/tmmbn.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtcp_packet/tmmbr.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtcp_packet/transport_feedback.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_format_h264.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_packet.cc View 4 chunks +7 lines, -7 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_packet_history.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/utility/source/audio_frame_operations_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/video_coding/codec_database.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/video_coding/codecs/vp9/vp9_frame_buffer_pool.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/video_coding/histogram.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M webrtc/modules/video_coding/video_codec_initializer.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M webrtc/sdk/objc/Framework/Classes/h264_video_toolbox_nalu.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M webrtc/system_wrappers/include/aligned_array.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/test/call_test.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M webrtc/test/frame_generator.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/video/end_to_end_tests.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M webrtc/video/video_quality_test.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M webrtc/video/video_send_stream.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/video/video_send_stream_tests.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M webrtc/voice_engine/test/auto_test/fakes/loudest_filter.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/voice_engine/utility.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M webrtc/voice_engine/voe_base_impl.cc View 1 chunk +1 line, -1 line 0 comments Download

Dependent Patchsets:

Messages

Total messages: 27 (20 generated)
kwiberg-webrtc
It'd be nice to get this reviewed quickly, before it starts conflicting with everything... :-)
4 years ago (2016-11-26 07:52:40 UTC) #15
ossu
This was the most exciting CL review I've done in ages! All the numbers are ...
4 years ago (2016-11-28 13:51:57 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2535593002/1
4 years ago (2016-11-28 22:37:38 UTC) #18
commit-bot: I haz the power
Try jobs failed on following builders: linux_msan on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/linux_msan/builds/15314)
4 years ago (2016-11-28 22:55:29 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2535593002/1
4 years ago (2016-11-28 23:21:06 UTC) #22
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-11-28 23:21:45 UTC) #25
commit-bot: I haz the power
4 years ago (2016-11-28 23:21:54 UTC) #27
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/af476c737fe008a185a99144731fd398e311ba65
Cr-Commit-Position: refs/heads/master@{#15280}

Powered by Google App Engine
This is Rietveld 408576698