Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(572)

Side by Side Diff: webrtc/base/bitbuffer.cc

Issue 2535593002: RTC_[D]CHECK_op: Remove "u" suffix on integer constants (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « webrtc/audio/audio_transport_proxy.cc ('k') | webrtc/base/filerotatingstream.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright 2015 The WebRTC Project Authors. All rights reserved. 2 * Copyright 2015 The WebRTC Project Authors. All rights reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
11 #include "webrtc/base/bitbuffer.h" 11 #include "webrtc/base/bitbuffer.h"
12 12
13 #include <algorithm> 13 #include <algorithm>
14 #include <limits> 14 #include <limits>
15 15
16 #include "webrtc/base/checks.h" 16 #include "webrtc/base/checks.h"
17 17
18 namespace { 18 namespace {
19 19
20 // Returns the lowest (right-most) |bit_count| bits in |byte|. 20 // Returns the lowest (right-most) |bit_count| bits in |byte|.
21 uint8_t LowestBits(uint8_t byte, size_t bit_count) { 21 uint8_t LowestBits(uint8_t byte, size_t bit_count) {
22 RTC_DCHECK_LE(bit_count, 8u); 22 RTC_DCHECK_LE(bit_count, 8);
23 return byte & ((1 << bit_count) - 1); 23 return byte & ((1 << bit_count) - 1);
24 } 24 }
25 25
26 // Returns the highest (left-most) |bit_count| bits in |byte|, shifted to the 26 // Returns the highest (left-most) |bit_count| bits in |byte|, shifted to the
27 // lowest bits (to the right). 27 // lowest bits (to the right).
28 uint8_t HighestBits(uint8_t byte, size_t bit_count) { 28 uint8_t HighestBits(uint8_t byte, size_t bit_count) {
29 RTC_DCHECK_LE(bit_count, 8u); 29 RTC_DCHECK_LE(bit_count, 8);
30 uint8_t shift = 8 - static_cast<uint8_t>(bit_count); 30 uint8_t shift = 8 - static_cast<uint8_t>(bit_count);
31 uint8_t mask = 0xFF << shift; 31 uint8_t mask = 0xFF << shift;
32 return (byte & mask) >> shift; 32 return (byte & mask) >> shift;
33 } 33 }
34 34
35 // Returns the highest byte of |val| in a uint8_t. 35 // Returns the highest byte of |val| in a uint8_t.
36 uint8_t HighestByte(uint64_t val) { 36 uint8_t HighestByte(uint64_t val) {
37 return static_cast<uint8_t>(val >> 56); 37 return static_cast<uint8_t>(val >> 56);
38 } 38 }
39 39
(...skipping 261 matching lines...) Expand 10 before | Expand all | Expand 10 after
301 return WriteExponentialGolomb((signed_val * 2) - 1); 301 return WriteExponentialGolomb((signed_val * 2) - 1);
302 } else { 302 } else {
303 if (val == std::numeric_limits<int32_t>::min()) 303 if (val == std::numeric_limits<int32_t>::min())
304 return false; // Not supported, would cause overflow. 304 return false; // Not supported, would cause overflow.
305 uint32_t signed_val = -val; 305 uint32_t signed_val = -val;
306 return WriteExponentialGolomb(signed_val * 2); 306 return WriteExponentialGolomb(signed_val * 2);
307 } 307 }
308 } 308 }
309 309
310 } // namespace rtc 310 } // namespace rtc
OLDNEW
« no previous file with comments | « webrtc/audio/audio_transport_proxy.cc ('k') | webrtc/base/filerotatingstream.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698