Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(261)

Side by Side Diff: webrtc/voice_engine/voe_base_impl.cc

Issue 2535593002: RTC_[D]CHECK_op: Remove "u" suffix on integer constants (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « webrtc/voice_engine/utility.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2012 The WebRTC project authors. All Rights Reserved. 2 * Copyright (c) 2012 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
(...skipping 517 matching lines...) Expand 10 before | Expand all | Expand 10 after
528 return StopSend(); 528 return StopSend();
529 } 529 }
530 530
531 int VoEBaseImpl::GetVersion(char version[1024]) { 531 int VoEBaseImpl::GetVersion(char version[1024]) {
532 if (version == nullptr) { 532 if (version == nullptr) {
533 shared_->SetLastError(VE_INVALID_ARGUMENT, kTraceError); 533 shared_->SetLastError(VE_INVALID_ARGUMENT, kTraceError);
534 return -1; 534 return -1;
535 } 535 }
536 536
537 std::string versionString = VoiceEngine::GetVersionString(); 537 std::string versionString = VoiceEngine::GetVersionString();
538 RTC_DCHECK_GT(1024u, versionString.size() + 1); 538 RTC_DCHECK_GT(1024, versionString.size() + 1);
539 char* end = std::copy(versionString.cbegin(), versionString.cend(), version); 539 char* end = std::copy(versionString.cbegin(), versionString.cend(), version);
540 end[0] = '\n'; 540 end[0] = '\n';
541 end[1] = '\0'; 541 end[1] = '\0';
542 return 0; 542 return 0;
543 } 543 }
544 544
545 int VoEBaseImpl::LastError() { return (shared_->statistics().LastError()); } 545 int VoEBaseImpl::LastError() { return (shared_->statistics().LastError()); }
546 546
547 int32_t VoEBaseImpl::StartPlayout() { 547 int32_t VoEBaseImpl::StartPlayout() {
548 if (!shared_->audio_device()->Playing()) { 548 if (!shared_->audio_device()->Playing()) {
(...skipping 218 matching lines...) Expand 10 before | Expand all | Expand 10 after
767 shared_->SetLastError(VE_CHANNEL_NOT_VALID, kTraceError, 767 shared_->SetLastError(VE_CHANNEL_NOT_VALID, kTraceError,
768 "AssociateSendChannel() failed to locate accociate_send_channel"); 768 "AssociateSendChannel() failed to locate accociate_send_channel");
769 return -1; 769 return -1;
770 } 770 }
771 771
772 channel_ptr->set_associate_send_channel(ch); 772 channel_ptr->set_associate_send_channel(ch);
773 return 0; 773 return 0;
774 } 774 }
775 775
776 } // namespace webrtc 776 } // namespace webrtc
OLDNEW
« no previous file with comments | « webrtc/voice_engine/utility.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698