webrtc/base/flags.cc - Issue 2535593002: RTC_[D]CHECK_op: Remove "u" suffix on integer constants

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/base/flags.cc

Issue 2535593002: RTC_[D]CHECK_op: Remove "u" suffix on integer constants (Closed)

Patch Set: Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: webrtc/base/flags.cc

diff --git a/webrtc/base/flags.cc b/webrtc/base/flags.cc

index a138b8fb9b6812c9e7d680d90de58de19504da1f..4fcd4acc11bf8f68d53c16150ee82e8426240ec4 100644

--- a/webrtc/base/flags.cc

+++ b/webrtc/base/flags.cc

@@ -258,7 +258,7 @@ int FlagList::SetFlagsFromCommandLine(int* argc, const char** argv,

void FlagList::Register(Flag* flag) {

RTC_DCHECK(flag);

- RTC_DCHECK_GT(strlen(flag->name()), 0u);

+ RTC_DCHECK_GT(strlen(flag->name()), 0);

// NOTE: Don't call Lookup() within Register because it accesses the name_

// of other flags in list_, and if the flags are coming from two different

// compilation units, the initialization order between them is undefined, and

« no previous file with comments | « webrtc/base/filerotatingstream.cc ('k') | webrtc/call/bitrate_allocator.cc » ('j') | no next file with comments »