webrtc/modules/audio_processing/beamformer/covariance_matrix_generator.cc - Issue 2535593002: RTC_[D]CHECK_op: Remove "u" suffix on integer constants

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/modules/audio_processing/beamformer/covariance_matrix_generator.cc

Issue 2535593002: RTC_[D]CHECK_op: Remove "u" suffix on integer constants (Closed)

Patch Set: Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « webrtc/modules/audio_processing/beamformer/array_util.cc ('k') | webrtc/modules/audio_processing/beamformer/nonlinear_beamformer.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: webrtc/modules/audio_processing/beamformer/covariance_matrix_generator.cc

diff --git a/webrtc/modules/audio_processing/beamformer/covariance_matrix_generator.cc b/webrtc/modules/audio_processing/beamformer/covariance_matrix_generator.cc

index 5ca79c6475c35464151ab4063982790debec1b1e..ae69073a894c9ed113f086c5dff517a29c05fc93 100644

--- a/webrtc/modules/audio_processing/beamformer/covariance_matrix_generator.cc

+++ b/webrtc/modules/audio_processing/beamformer/covariance_matrix_generator.cc

@@ -27,7 +27,7 @@ float BesselJ0(float x) {

// Calculates the Euclidean norm for a row vector.

float Norm(const ComplexMatrix<float>& x) {

- RTC_CHECK_EQ(1u, x.num_rows());

+ RTC_CHECK_EQ(1, x.num_rows());

const size_t length = x.num_columns();

const complex<float>* elems = x.elements()[0];

float result = 0.f;

@@ -94,7 +94,7 @@ void CovarianceMatrixGenerator::PhaseAlignmentMasks(

const std::vector<Point>& geometry,

float angle,

ComplexMatrix<float>* mat) {

- RTC_CHECK_EQ(1u, mat->num_rows());

+ RTC_CHECK_EQ(1, mat->num_rows());

RTC_CHECK_EQ(geometry.size(), mat->num_columns());

float freq_in_hertz =